Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: native_client_sdk/src/tools/common.mk

Issue 1388503003: [NaCl SDK] Remove newlib toolchain from the SDK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/tests/sdk_util_test/example.dsc ('k') | native_client_sdk/src/tools/nacl_config.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tools/common.mk
diff --git a/native_client_sdk/src/tools/common.mk b/native_client_sdk/src/tools/common.mk
index 1dbc3d69e44f59781f06d6895e123bcee6a44fca..d385bcf7fa2e648e946c84413d25adca486d98e9 100644
--- a/native_client_sdk/src/tools/common.mk
+++ b/native_client_sdk/src/tools/common.mk
@@ -10,14 +10,14 @@
#
# Toolchain
#
-# By default the VALID_TOOLCHAINS list contains pnacl, newlib and glibc. If
-# your project only builds in one or the other then this should be overridden
+# By default the VALID_TOOLCHAINS list contains pnacl, clang-newlib and glibc.
+# If your project only builds in one or the other then this should be overridden
# accordingly.
#
ifneq ($(ENABLE_BIONIC),)
-ALL_TOOLCHAINS ?= pnacl newlib glibc clang-newlib bionic
+ALL_TOOLCHAINS ?= pnacl glibc clang-newlib bionic
else
-ALL_TOOLCHAINS ?= pnacl newlib glibc clang-newlib
+ALL_TOOLCHAINS ?= pnacl glibc clang-newlib
endif
VALID_TOOLCHAINS ?= $(ALL_TOOLCHAINS)
@@ -428,7 +428,7 @@ ifneq (,$(findstring $(TOOLCHAIN),win))
include $(NACL_SDK_ROOT)/tools/host_vc.mk
endif
-ifneq (,$(findstring $(TOOLCHAIN),glibc newlib bionic clang-newlib))
+ifneq (,$(findstring $(TOOLCHAIN),glibc bionic clang-newlib))
include $(NACL_SDK_ROOT)/tools/nacl_gcc.mk
endif
« no previous file with comments | « native_client_sdk/src/tests/sdk_util_test/example.dsc ('k') | native_client_sdk/src/tools/nacl_config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698