Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: native_client_sdk/src/build_tools/tests/parse_dsc_test.py

Issue 1388503003: [NaCl SDK] Remove newlib toolchain from the SDK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/tests/parse_dsc_test.py
diff --git a/native_client_sdk/src/build_tools/tests/parse_dsc_test.py b/native_client_sdk/src/build_tools/tests/parse_dsc_test.py
index 77f96b801cfc912e473d9445e664ed0a070c7d75..ae1aab3eef3a3887f881062cdc38efcdc2b3a3aa 100755
--- a/native_client_sdk/src/build_tools/tests/parse_dsc_test.py
+++ b/native_client_sdk/src/build_tools/tests/parse_dsc_test.py
@@ -19,7 +19,7 @@ import generate_make
import parse_dsc
BASIC_DESC = {
- 'TOOLS': ['newlib', 'glibc'],
+ 'TOOLS': ['clang-newlib', 'glibc'],
'TARGETS': [
{
'NAME' : 'hello_world',
@@ -68,17 +68,17 @@ class TestValidateFormat(unittest.TestCase):
def testBadValue(self):
testdesc = copy.deepcopy(BASIC_DESC)
- testdesc['TOOLS'] = ['newlib', 'glibc', 'badtool']
+ testdesc['TOOLS'] = ['clang-newlib', 'glibc', 'badtool']
self._validate(testdesc, 'Value badtool not expected in TOOLS.')
def testExpectStr(self):
testdesc = copy.deepcopy(BASIC_DESC)
- testdesc['TOOLS'] = ['newlib', True, 'glibc']
+ testdesc['TOOLS'] = ['clang-newlib', True, 'glibc']
self._validate(testdesc, 'Value True not expected in TOOLS.')
def testExpectList(self):
testdesc = copy.deepcopy(BASIC_DESC)
- testdesc['TOOLS'] = 'newlib'
+ testdesc['TOOLS'] = 'clang-newlib'
self._validate(testdesc, 'Key TOOLS expects LIST not STR.')
# TODO(bradnelson): Add test which generates a real make and runs it.
« no previous file with comments | « native_client_sdk/src/build_tools/tests/build_artifacts_test.py ('k') | native_client_sdk/src/examples/demo/drive/example.dsc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698