Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 13869005: Dropping the scons generator. (Closed)

Created:
7 years, 8 months ago by bradn
Modified:
7 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Dropping the scons generator. The scons generator has not been used for some time and is known to no longer be at parity with the other generators. Dropping it to reduce the ongoing maintenance burden. BUG=None TEST=None R=mark@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1613

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1554 lines) Patch
M DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M MANIFEST View 2 chunks +0 lines, -2 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M buildbot/buildbot_run.py View 2 chunks +1 line, -3 lines 0 comments Download
M pylib/gyp/MSVSNew.py View 1 chunk +1 line, -1 line 0 comments Download
D pylib/gyp/SCons.py View 1 chunk +0 lines, -199 lines 0 comments Download
D pylib/gyp/generator/scons.py View 1 chunk +0 lines, -1072 lines 0 comments Download
M test/actions-none/gyptest-none.py View 1 chunk +0 lines, -3 lines 0 comments Download
M test/actions/src/subdir1/counter.py View 1 chunk +3 lines, -5 lines 0 comments Download
M test/additional-targets/gyptest-additional.py View 1 chunk +1 line, -1 line 0 comments Download
M test/builddir/src/builddir.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M test/configurations/invalid/gyptest-configurations.py View 1 chunk +0 lines, -3 lines 0 comments Download
M test/dependencies/gyptest-lib-only.py View 1 chunk +1 line, -1 line 0 comments Download
M test/errors/gyptest-errors.py View 1 chunk +3 lines, -3 lines 0 comments Download
M test/external-cross-compile/gyptest-cross.py View 1 chunk +0 lines, -4 lines 0 comments Download
M test/generator-output/rules/subdir1/executable.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M test/include_dirs/gyptest-all.py View 1 chunk +0 lines, -3 lines 0 comments Download
M test/include_dirs/gyptest-default.py View 1 chunk +0 lines, -3 lines 0 comments Download
M test/lib/TestGyp.py View 3 chunks +1 line, -74 lines 0 comments Download
M test/multiple-targets/gyptest-all.py View 1 chunk +0 lines, -2 lines 0 comments Download
M test/multiple-targets/gyptest-default.py View 1 chunk +1 line, -3 lines 0 comments Download
M test/rules/src/subdir1/executable.gyp View 1 chunk +1 line, -1 line 0 comments Download
D test/scons_tools/gyptest-tools.py View 1 chunk +0 lines, -26 lines 0 comments Download
D test/scons_tools/site_scons/site_tools/this_tool.py View 1 chunk +0 lines, -10 lines 0 comments Download
D test/scons_tools/tools.c View 1 chunk +0 lines, -13 lines 0 comments Download
D test/scons_tools/tools.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M test/sibling/src/build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/standalone-static-library/gyptest-standalone-static-library.py View 2 chunks +2 lines, -8 lines 0 comments Download
M test/subdirectory/gyptest-top-all.py View 1 chunk +1 line, -1 line 0 comments Download
M test/subdirectory/gyptest-top-default.py View 1 chunk +1 line, -1 line 0 comments Download
D test/variants/gyptest-variants.py View 1 chunk +0 lines, -45 lines 0 comments Download
D test/variants/src/variants.c View 1 chunk +0 lines, -13 lines 0 comments Download
D test/variants/src/variants.gyp View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bradn
7 years, 8 months ago (2013-04-17 18:18:57 UTC) #1
Mark Mentovai
LGTM
7 years, 8 months ago (2013-04-17 18:19:45 UTC) #2
bradn
7 years, 8 months ago (2013-04-17 18:21:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698