Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/errors/gyptest-errors.py

Issue 13869005: Dropping the scons generator. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/dependencies/gyptest-lib-only.py ('k') | test/external-cross-compile/gyptest-cross.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/errors/gyptest-errors.py
===================================================================
--- test/errors/gyptest-errors.py (revision 1611)
+++ test/errors/gyptest-errors.py (working copy)
@@ -11,9 +11,9 @@
import TestGyp
import TestCmd
-# TODO(sbc): Remove the need for match_re below, and make scons
-# error messages consistent with other generators by removing
-# input.py:generator_wants_absolute_build_file_paths.
+# TODO(sbc): Remove the use of match_re below, done because scons
+# error messages were not consistent with other generators.
+# Also remove input.py:generator_wants_absolute_build_file_paths.
test = TestGyp.TestGyp()
« no previous file with comments | « test/dependencies/gyptest-lib-only.py ('k') | test/external-cross-compile/gyptest-cross.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698