Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/configurations/invalid/gyptest-configurations.py

Issue 13869005: Dropping the scons generator. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/builddir/src/builddir.gypi ('k') | test/dependencies/gyptest-lib-only.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/configurations/invalid/gyptest-configurations.py
===================================================================
--- test/configurations/invalid/gyptest-configurations.py (revision 1611)
+++ test/configurations/invalid/gyptest-configurations.py (working copy)
@@ -27,9 +27,6 @@
test = TestGyp.TestGyp()
-if test.format == 'scons':
- test.skip_test('TODO: http://code.google.com/p/gyp/issues/detail?id=176\n')
-
for test_key in invalid_configuration_keys:
test.run_gyp('%s.gyp' % test_key, status=1, stderr=None)
expect = ['%s not allowed in the Debug configuration, found in target '
« no previous file with comments | « test/builddir/src/builddir.gypi ('k') | test/dependencies/gyptest-lib-only.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698