PRESUBMIT.py - Issue 13869005: Dropping the scons generator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PRESUBMIT.py

Issue 13869005: Dropping the scons generator. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012 Google Inc. All rights reserved.	1 # Copyright (c) 2012 Google Inc. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5	5

6 """Top-level presubmit script for GYP.	6 """Top-level presubmit script for GYP.

7	7

8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

9 for more details about the presubmit API built into gcl.	9 for more details about the presubmit API built into gcl.

10 """	10 """

11	11

12	12

13 PYLINT_BLACKLIST = [	13 PYLINT_BLACKLIST = [

14 # TODO: fix me.	14 # TODO: fix me.

15 # From SCons, not done in google style.	15 # From SCons, not done in google style.

16 'test/lib/TestCmd.py',	16 'test/lib/TestCmd.py',

17 'test/lib/TestCommon.py',	17 'test/lib/TestCommon.py',

18 'test/lib/TestGyp.py',	18 'test/lib/TestGyp.py',

19 # Needs style fix.	19 # Needs style fix.

20 'pylib/gyp/generator/scons.py',

21 'pylib/gyp/generator/xcode.py',	20 'pylib/gyp/generator/xcode.py',

22 ]	21 ]

23	22

24	23

25 PYLINT_DISABLED_WARNINGS = [	24 PYLINT_DISABLED_WARNINGS = [

26 # TODO: fix me.	25 # TODO: fix me.

27 # Many tests include modules they don't use.	26 # Many tests include modules they don't use.

28 'W0611',	27 'W0611',

29 # Include order doesn't properly include local files?	28 # Include order doesn't properly include local files?

30 'F0401',	29 'F0401',

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
107 output_api,	106 output_api,

108 black_list=PYLINT_BLACKLIST,	107 black_list=PYLINT_BLACKLIST,

109 disabled_warnings=PYLINT_DISABLED_WARNINGS))	108 disabled_warnings=PYLINT_DISABLED_WARNINGS))

110 finally:	109 finally:

111 sys.path = old_sys_path	110 sys.path = old_sys_path

112 return report	111 return report

113	112

114	113

115 def GetPreferredTrySlaves():	114 def GetPreferredTrySlaves():

116 return ['gyp-win32', 'gyp-win64', 'gyp-linux', 'gyp-mac', 'gyp-android']	115 return ['gyp-win32', 'gyp-win64', 'gyp-linux', 'gyp-mac', 'gyp-android']

OLD	NEW

« no previous file with comments | « MANIFEST ('k') | buildbot/buildbot_run.py » ('j') | no next file with comments »