Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: test/actions/src/subdir1/counter.py

Issue 13869005: Dropping the scons generator. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/actions-none/gyptest-none.py ('k') | test/additional-targets/gyptest-additional.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/actions/src/subdir1/counter.py
===================================================================
--- test/actions/src/subdir1/counter.py (revision 1611)
+++ test/actions/src/subdir1/counter.py (working copy)
@@ -29,11 +29,9 @@
pass
# Save the count in a file that is undeclared, and thus hidden, to gyp. We need
-# to do this because, prior to running commands, scons deletes any declared
-# outputs, so we would lose our count if we just wrote to the given output file.
-# (The other option is to use Precious() in the scons generator, but that seems
-# too heavy-handed just to support this somewhat unrealistic test case, and
-# might lead to unintended side-effects).
+# to do this because, prior to running commands, some build systems deletes
+# any declared outputs, so we would lose our count if we just wrote to the
+# given output file.
open(persistoutput, 'w').write('%d' % (count))
# Only write the given output file if the count has changed.
« no previous file with comments | « test/actions-none/gyptest-none.py ('k') | test/additional-targets/gyptest-additional.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698