Cleanup timing state machine

Cleanup timing state machine

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/cb54e8ed4567adabd2ca8b49f7493effd2614158

[joshualitt, 2015-10-05 17:55:04]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com, jvanverth@google.com, robertphillips@google.com

[joshualitt, 2015-10-05 17:55:04]

This CL cleans up TimingStateMachine.  In a follow on I will tackle refactoring
out the common parts of the VisualModules to the base class

[robertphillips, 2015-10-05 18:37:37]

https://codereview.chromium.org/1386933002/diff/20001/tools/VisualBench/Timin...
File tools/VisualBench/TimingStateMachine.cpp (right):

https://codereview.chromium.org/1386933002/diff/20001/tools/VisualBench/Timin...
tools/VisualBench/TimingStateMachine.cpp:16: 
Why isn't preWarmBetweenSamples a member variable ?

https://codereview.chromium.org/1386933002/diff/20001/tools/VisualBench/Timin...
tools/VisualBench/TimingStateMachine.cpp:31: fTimer.start();
Why not just set fInnerState to kTiming_InnerState here ?

https://codereview.chromium.org/1386933002/diff/20001/tools/VisualBench/Timin...
tools/VisualBench/TimingStateMachine.cpp:71: 
Would it be cleaner to fold this into nextFrame (not sure - really asking) ?

[joshualitt, 2015-10-05 18:59:45]

On 2015/10/05 18:37:37, robertphillips wrote:
>
https://codereview.chromium.org/1386933002/diff/20001/tools/VisualBench/Timin...
> File tools/VisualBench/TimingStateMachine.cpp (right):
> 
>
https://codereview.chromium.org/1386933002/diff/20001/tools/VisualBench/Timin...
> tools/VisualBench/TimingStateMachine.cpp:16: 
> Why isn't preWarmBetweenSamples a member variable ?
> 
>
https://codereview.chromium.org/1386933002/diff/20001/tools/VisualBench/Timin...
> tools/VisualBench/TimingStateMachine.cpp:31: fTimer.start();
> Why not just set fInnerState to kTiming_InnerState here ?
> 
>
https://codereview.chromium.org/1386933002/diff/20001/tools/VisualBench/Timin...
> tools/VisualBench/TimingStateMachine.cpp:71: 
> Would it be cleaner to fold this into nextFrame (not sure - really asking) ?

feedback incorporated

[robertphillips, 2015-10-05 20:03:24]

lgtm + question

https://codereview.chromium.org/1386933002/diff/60001/tools/VisualBench/Timin...
File tools/VisualBench/TimingStateMachine.cpp (right):

https://codereview.chromium.org/1386933002/diff/60001/tools/VisualBench/Timin...
tools/VisualBench/TimingStateMachine.cpp:55: }
Is this fall through intentional? If so it needs a "// fallthru".

[joshualitt, 2015-10-05 20:25:18]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-10-05 20:25:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1386933002/#ps80001
(title: "tweaks")

[commit-bot: I haz the power, 2015-10-05 20:25:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386933002/80001

[commit-bot: I haz the power, 2015-10-05 20:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 20:26:25]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[joshualitt, 2015-10-05 20:51:50]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-10-05 20:51:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1386933002/#ps90001
(title: "rebase")

[commit-bot: I haz the power, 2015-10-05 20:52:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386933002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386933002/90001

[commit-bot: I haz the power, 2015-10-05 20:59:36]

Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/cb54e8ed4567adabd2ca8b49f7493effd2614158