Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1884)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138273007: Convert GN single-item list concat to use lists. (Closed)

Created:
6 years, 11 months ago by brettw
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Convert GN single-item list concat to use lists. R=scottmg@chromium.org, scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245594

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -140 lines) Patch
M base/BUILD.gn View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M base/test/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M base/third_party/symbolize/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M base/third_party/xdg_mime/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 4 chunks +8 lines, -8 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/libpng/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/re2/BUILD.gn View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/secondary/crypto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/ipc/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/net/BUILD.gn View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/secondary/net/third_party/nss/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/gn/secondary/skia/BUILD.gn View 10 chunks +15 lines, -15 lines 0 comments Download
M tools/gn/secondary/testing/gtest/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/secondary/third_party/expat/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/secondary/third_party/icu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/third_party/leveldatabase/BUILD.gn View 20 chunks +39 lines, -39 lines 0 comments Download
M tools/gn/secondary/third_party/libevent/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/secondary/third_party/libusb/BUILD.gn View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/gn/secondary/third_party/libxml/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/secondary/third_party/sfntly/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/secondary/third_party/snappy/BUILD.gn View 3 chunks +7 lines, -7 lines 0 comments Download
M tools/gn/secondary/third_party/zlib/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 11 months ago (2014-01-15 06:42:55 UTC) #1
scottmg
lgtm Though now that I stare at them, I'm not sure about the inner spaces. ...
6 years, 11 months ago (2014-01-15 06:55:03 UTC) #2
brettw
6 years, 11 months ago (2014-01-17 20:19:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r245594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698