Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: tools/gn/secondary/chrome/BUILD.gn

Issue 138273007: Convert GN single-item list concat to use lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/secondary/crypto/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//crypto/ssl/flags.gni") 5 import("//crypto/ssl/flags.gni")
6 import("//tools/grit/grit_rule.gni") 6 import("//tools/grit/grit_rule.gni")
7 7
8 executable("chrome") { 8 executable("chrome") {
9 sources = [ 9 sources = [
10 "app/breakpad_field_trial_win.cc", 10 "app/breakpad_field_trial_win.cc",
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 ":common", 44 ":common",
45 ":debugger", 45 ":debugger",
46 ":plugin", 46 ":plugin",
47 ":renderer", 47 ":renderer",
48 ":utility", 48 ":utility",
49 "//base", 49 "//base",
50 ] 50 ]
51 51
52 # TODO(brettw) this isn't right for all platforms. 52 # TODO(brettw) this isn't right for all platforms.
53 if (!use_aura) { 53 if (!use_aura) {
54 sources -= "app/chrome_exe_main_aura.cc" 54 sources -= [ "app/chrome_exe_main_aura.cc" ]
55 } 55 }
56 56
57 if (!is_win) { 57 if (!is_win) {
58 sources -= [ 58 sources -= [
59 "app/client_util.cc", 59 "app/client_util.cc",
60 "app/client_util.h", 60 "app/client_util.h",
61 ] 61 ]
62 } 62 }
63 } 63 }
64 64
65 static_library("browser") { 65 static_library("browser") {
66 external = true 66 external = true
67 67
68 if (is_linux) { 68 if (is_linux) {
69 libs = [ "dl" ] 69 libs = [ "dl" ]
70 if (toolkit_uses_gtk) { 70 if (toolkit_uses_gtk) {
71 libs += "gconf-2" 71 libs += [ "gconf-2" ]
72 } 72 }
73 } 73 }
74 if (is_linux) { 74 if (is_linux) {
75 configs += [ 75 configs += [
76 "//build/config/linux:x11", 76 "//build/config/linux:x11",
77 ] 77 ]
78 } 78 }
79 79
80 deps = [ 80 deps = [
81 "//third_party/expat", 81 "//third_party/expat",
82 ] 82 ]
83 } 83 }
84 84
85 static_library("common") { 85 static_library("common") {
86 external = true 86 external = true
87 87
88 if (use_nss && is_linux) { 88 if (use_nss && is_linux) {
89 # common/net uses NSS. 89 # common/net uses NSS.
90 # TODO(brettw) have a better way to express this without having to do 90 # TODO(brettw) have a better way to express this without having to do
91 # "if (use_nss)" everywhere. 91 # "if (use_nss)" everywhere.
92 configs += "//third_party/nss:nss_linux_config" 92 configs += [ "//third_party/nss:nss_linux_config" ]
93 } 93 }
94 deps = [ 94 deps = [
95 ] 95 ]
96 } 96 }
97 97
98 # TODO(brettw) move to browser/devtools/BUILD.gn 98 # TODO(brettw) move to browser/devtools/BUILD.gn
99 source_set("debugger") { 99 source_set("debugger") {
100 sources = [ 100 sources = [
101 "browser/devtools/adb/android_rsa.cc", 101 "browser/devtools/adb/android_rsa.cc",
102 "browser/devtools/adb/android_rsa.h", 102 "browser/devtools/adb/android_rsa.h",
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 # ":theme_resources_gen", 299 # ":theme_resources_gen",
300 # #"//ui:ui_resources", 300 # #"//ui:ui_resources",
301 # ] 301 # ]
302 #} 302 #}
303 # 303 #
304 ## TODO(brettw) rename "app_theme_resources" or something when we don't support 304 ## TODO(brettw) rename "app_theme_resources" or something when we don't support
305 ## GYP any more. This name is required to match the GYP build. 305 ## GYP any more. This name is required to match the GYP build.
306 #grit("theme_resources_gen") { 306 #grit("theme_resources_gen") {
307 # source = "app/theme/theme_resources.grd" 307 # source = "app/theme/theme_resources.grd"
308 #} 308 #}
OLDNEW
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/secondary/crypto/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698