Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Side by Side Diff: tools/gn/secondary/third_party/icu/BUILD.gn

Issue 138273007: Convert GN single-item list concat to use lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Shared config used by ICU and all dependents. 5 # Shared config used by ICU and all dependents.
6 config("icu_config") { 6 config("icu_config") {
7 defines = [ 7 defines = [
8 "U_USING_ICU_NAMESPACE=0", 8 "U_USING_ICU_NAMESPACE=0",
9 ] 9 ]
10 include_dirs = [ 10 include_dirs = [
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 "//build/config/compiler:chromium_code", 388 "//build/config/compiler:chromium_code",
389 ] 389 ]
390 configs += [ 390 configs += [
391 "//build/config/compiler:rtti", 391 "//build/config/compiler:rtti",
392 "//build/config/compiler:no_chromium_code", 392 "//build/config/compiler:no_chromium_code",
393 ] 393 ]
394 394
395 direct_dependent_configs = [ ":icu_config" ] 395 direct_dependent_configs = [ ":icu_config" ]
396 396
397 if (!is_win) { 397 if (!is_win) {
398 sources -= "source/stubdata/stubdata.c" 398 sources -= [ "source/stubdata/stubdata.c" ]
399 } 399 }
400 } 400 }
401 401
402 if (is_win) { 402 if (is_win) {
403 # On Windows the target DLL is pre-built so just use a copy rule. 403 # On Windows the target DLL is pre-built so just use a copy rule.
404 copy("icudata") { 404 copy("icudata") {
405 external = true 405 external = true
406 sources = [ "windows/icudt.dll" ] 406 sources = [ "windows/icudt.dll" ]
407 outputs = [ "$root_out_dir/icudt.dll" ] 407 outputs = [ "$root_out_dir/icudt.dll" ]
408 } 408 }
409 } else { 409 } else {
410 static_library("icudata") { 410 static_library("icudata") {
411 external = true 411 external = true
412 sources = [ 412 sources = [
413 # These are hand-generated, but will do for now. The linux version is an 413 # These are hand-generated, but will do for now. The linux version is an
414 # identical copy of the (mac) icudt46l_dat.S file, modulo removal of the 414 # identical copy of the (mac) icudt46l_dat.S file, modulo removal of the
415 # .private_extern and .const directives and with no leading underscore on 415 # .private_extern and .const directives and with no leading underscore on
416 # the icudt46_dat symbol. 416 # the icudt46_dat symbol.
417 "android/icudt46l_dat.S", 417 "android/icudt46l_dat.S",
418 "linux/icudt46l_dat.S", 418 "linux/icudt46l_dat.S",
419 "mac/icudt46l_dat.S", 419 "mac/icudt46l_dat.S",
420 ] 420 ]
421 defines = [ "U_HIDE_DATA_SYMBOL" ] 421 defines = [ "U_HIDE_DATA_SYMBOL" ]
422 422
423 # TODO(brettw) support use_system_icu and icu_use_data_file_flag. 423 # TODO(brettw) support use_system_icu and icu_use_data_file_flag.
424 } 424 }
425 } 425 }
OLDNEW
« no previous file with comments | « tools/gn/secondary/third_party/expat/BUILD.gn ('k') | tools/gn/secondary/third_party/leveldatabase/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698