Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 138273007: Convert GN single-item list concat to use lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/third_party/xdg_mime/BUILD.gn ('k') | build/config/clang/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 791074f12f2a03ad2679db4e482cda9566ed84d6..9239c24e416ddd87627bf7763144c0b22d94e25c 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -328,18 +328,18 @@ if (is_win) {
"//build/config/win:sdk",
]
} else if (is_clang) {
- native_compiler_configs += "//build/config/clang:find_bad_constructs"
+ native_compiler_configs += [ "//build/config/clang:find_bad_constructs" ]
}
# Optimizations and debug checking.
if (is_debug) {
- native_compiler_configs += "//build/config:debug"
+ native_compiler_configs += [ "//build/config:debug" ]
default_optimization_config = "//build/config/compiler:no_optimize"
} else {
- native_compiler_configs += "//build/config:release"
+ native_compiler_configs += [ "//build/config:release" ]
default_optimization_config = "//build/config/compiler:optimize"
}
-native_compiler_configs += default_optimization_config
+native_compiler_configs += [ default_optimization_config ]
# Symbol setup.
if (is_clang && (is_linux || is_android)) {
@@ -357,7 +357,7 @@ if (is_clang && (is_linux || is_android)) {
} else {
assert(false, "Bad value for symbol_level.")
}
-native_compiler_configs += default_symbols_config
+native_compiler_configs += [ default_symbols_config ]
# Windows linker setup for EXEs and DLLs.
if (is_win) {
@@ -383,9 +383,9 @@ set_defaults("executable") {
if (is_win) {
configs += windows_linker_configs
} else if (is_mac) {
- configs += "//build/config/mac:mac_dynamic_flags"
+ configs += [ "//build/config/mac:mac_dynamic_flags" ]
} else if (is_linux) {
- configs += "//build/config/linux:executable_ldconfig"
+ configs += [ "//build/config/linux:executable_ldconfig" ]
}
}
@@ -398,7 +398,7 @@ set_defaults("shared_library") {
if (is_win) {
configs += windows_linker_configs
} else if (is_mac) {
- configs += "//build/config/mac:mac_dynamic_flags"
+ configs += [ "//build/config/mac:mac_dynamic_flags" ]
}
}
« no previous file with comments | « base/third_party/xdg_mime/BUILD.gn ('k') | build/config/clang/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698