Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: tools/gn/secondary/chrome/BUILD.gn

Issue 138273007: Convert GN single-item list concat to use lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/secondary/crypto/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/chrome/BUILD.gn
diff --git a/tools/gn/secondary/chrome/BUILD.gn b/tools/gn/secondary/chrome/BUILD.gn
index 1d6217e9bede73b4549bd9423da628a0a9246be3..7ef82aa50209bcca46f3fbbeaf3bd3e844628dac 100644
--- a/tools/gn/secondary/chrome/BUILD.gn
+++ b/tools/gn/secondary/chrome/BUILD.gn
@@ -51,7 +51,7 @@ executable("chrome") {
# TODO(brettw) this isn't right for all platforms.
if (!use_aura) {
- sources -= "app/chrome_exe_main_aura.cc"
+ sources -= [ "app/chrome_exe_main_aura.cc" ]
}
if (!is_win) {
@@ -68,7 +68,7 @@ static_library("browser") {
if (is_linux) {
libs = [ "dl" ]
if (toolkit_uses_gtk) {
- libs += "gconf-2"
+ libs += [ "gconf-2" ]
}
}
if (is_linux) {
@@ -89,7 +89,7 @@ static_library("common") {
# common/net uses NSS.
# TODO(brettw) have a better way to express this without having to do
# "if (use_nss)" everywhere.
- configs += "//third_party/nss:nss_linux_config"
+ configs += [ "//third_party/nss:nss_linux_config" ]
}
deps = [
]
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/secondary/crypto/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698