Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1379923005: Remove const from `const int loops`. (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove const from `const int loops`. This drives me nuts, and prevents `while (loops --> 0)`. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a1ebeb25e9acfcd801e089e063311d716b83b8a5

Patch Set 1 #

Patch Set 2 : n too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -203 lines) Patch
M bench/AAClipBench.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M bench/AlternatingColorPatternBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/Benchmark.h View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/Benchmark.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BezierBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BigPathBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/BitmapRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapRegionDecoderBench.h View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapRegionDecoderBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapScaleBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BlurBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BlurImageFilterBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BlurRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BlurRectsBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BlurRoundRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ChartBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ChecksumBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ChromeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/CmapBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/CodecBench.h View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/CodecBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/ColorCubeBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/ColorFilterBench.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M bench/ColorPrivBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ControlBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/CoverageBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/DashBench.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M bench/DecodingBench.h View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/DecodingBench.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M bench/DisplacementBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/DrawBitmapAABench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ETCBitmapBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/FSRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/FontCacheBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/FontScalerBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GLBench.h View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/GLBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GLInstancedArraysBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/GLVec4ScalarBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/GLVertexAttributesBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/GMBench.h View 1 chunk +1 line, -1 line 0 comments Download
M bench/GMBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GameBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GeometryBench.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M bench/GrMemoryPoolBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/GrResourceCacheBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/GradientBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/HairlinePathBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ImageBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ImageCacheBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ImageFilterCollapse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ImageFilterDAGBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/InterpBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/LightingBench.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M bench/LineBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MagnifierBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MathBench.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M bench/Matrix44Bench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MatrixBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MatrixConvolutionBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MemoryBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MemsetBench.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M bench/MergeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MipMapBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MorphologyBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/MutexBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/PatchBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/PatchGridBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/PathBench.cpp View 15 chunks +15 lines, -15 lines 0 comments Download
M bench/PathIterBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/PerlinNoiseBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/PictureNestingBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/PictureOverheadBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/PicturePlaybackBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/PremulAndUnpremulAlphaOpsBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RTreeBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/ReadPixBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RecordingBench.h View 1 chunk +1 line, -1 line 0 comments Download
M bench/RecordingBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RectBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/RectanizerBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RectoriBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RefCntBench.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M bench/RegionBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RegionContainBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RepeatTileBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RotatedRectBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/SKPBench.h View 1 chunk +1 line, -1 line 0 comments Download
M bench/SKPBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ScalarBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/ShaderMaskBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/Sk4fBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/SkGlyphCacheBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/SkipZeroesBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/SortBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/StrokeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/TableBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/TextBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/TextBlobBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/TileBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/VertBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/WritePixelsBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/WriterBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/XfermodeBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/subset/SubsetSingleBench.h View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/subset/SubsetSingleBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/subset/SubsetTranslateBench.h View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/subset/SubsetTranslateBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/subset/SubsetZoomBench.h View 1 1 chunk +1 line, -1 line 0 comments Download
M bench/subset/SubsetZoomBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualLightweightBenchModule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualSKPBench.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualSKPBench.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379923005/1
5 years, 2 months ago (2015-10-01 15:33:11 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/3558)
5 years, 2 months ago (2015-10-01 15:35:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379923005/20001
5 years, 2 months ago (2015-10-01 15:38:53 UTC) #6
mtklein_C
5 years, 2 months ago (2015-10-01 15:43:56 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 15:45:34 UTC) #10
joshualitt
On 2015/10/01 15:45:34, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 2 months ago (2015-10-01 16:41:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379923005/20001
5 years, 2 months ago (2015-10-01 16:42:24 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 16:43:43 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a1ebeb25e9acfcd801e089e063311d716b83b8a5

Powered by Google App Engine
This is Rietveld 408576698