Enforce marking "override" for functions overriding Blink.

Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
R=thakis@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}

Committed: https://chromium.googlesource.com/chromium/src/+/09b359e586c35cf06a985dcf326a31aea4a1c6db

[Avi (use Gerrit), 2015-09-26 18:07:57]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-26 18:08:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/1

[commit-bot: I haz the power, 2015-09-26 18:15:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-26 18:15:17]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2015-09-26 18:19:53]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-26 18:20:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/20001

[commit-bot: I haz the power, 2015-09-26 19:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-26 19:41:58]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2015-10-05 14:58:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-05 14:58:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/20001

[commit-bot: I haz the power, 2015-10-05 18:01:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 18:01:19]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Avi (use Gerrit), 2015-12-03 23:48:14]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 23:52:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/40001

[commit-bot: I haz the power, 2015-12-03 23:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 23:59:35]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2015-12-04 00:13:07]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 00:14:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/60001

[Avi (use Gerrit), 2015-12-04 00:23:02]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 00:27:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2015-12-04 00:28:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/80001

[commit-bot: I haz the power, 2015-12-04 01:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 01:28:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Avi (use Gerrit), 2015-12-04 01:37:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2015-12-04 01:37:15]

Description was changed from

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
==========

to

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2015-12-04 01:41:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/100001

[Avi (use Gerrit), 2015-12-04 01:41:23]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 01:46:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/120001

[commit-bot: I haz the power, 2015-12-04 02:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 02:38:55]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Avi (use Gerrit), 2015-12-04 14:55:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 14:55:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/140001

[commit-bot: I haz the power, 2015-12-04 15:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 15:40:42]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2015-12-04 15:43:39]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 15:43:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/160001

[commit-bot: I haz the power, 2015-12-04 16:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 16:20:59]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Avi (use Gerrit), 2015-12-04 17:22:33]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 17:23:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/180001

[Avi (use Gerrit), 2015-12-04 17:23:56]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2015-12-04 17:24:25]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 17:25:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/200001

[commit-bot: I haz the power, 2015-12-04 18:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 18:18:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Avi (use Gerrit), 2015-12-04 18:48:38]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 18:49:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/220001

[commit-bot: I haz the power, 2015-12-04 19:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 19:36:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2015-12-04 19:41:48]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 19:43:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/240001

[commit-bot: I haz the power, 2015-12-04 20:22:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 20:22:45]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Avi (use Gerrit), 2015-12-04 20:25:11]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 20:25:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/260001

[commit-bot: I haz the power, 2015-12-04 21:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 21:38:10]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Avi (use Gerrit), 2015-12-06 00:52:57]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 00:54:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/280001

[commit-bot: I haz the power, 2015-12-06 02:22:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 02:22:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2015-12-06 04:54:11]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 04:54:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/300001

[commit-bot: I haz the power, 2015-12-06 05:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 05:20:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[Avi (use Gerrit), 2015-12-06 18:27:16]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 18:27:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/320001

[commit-bot: I haz the power, 2015-12-06 20:12:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 20:12:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2015-12-06 20:30:07]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 20:30:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/340001

[commit-bot: I haz the power, 2015-12-06 21:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 21:44:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2015-12-06 22:27:40]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 22:28:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/360001

[commit-bot: I haz the power, 2015-12-07 00:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 00:22:42]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2015-12-07 00:23:54]

avi@chromium.org changed reviewers:
+ thakis@chromium.org

[Avi (use Gerrit), 2015-12-07 00:23:55]

Yes?

[Nico, 2015-12-07 03:58:55]

nice, lgtm!

https://codereview.chromium.org/1370923002/diff/360001/content/child/blink_pl...
File content/child/blink_platform_impl.h (right):

https://codereview.chromium.org/1370923002/diff/360001/content/child/blink_pl...
content/child/blink_platform_impl.h:135: virtual TraceEventHandle addTraceEvent(
Hm, I suppose this was supposed to be an override too? If it isn't, can it go
away?

[Avi (use Gerrit), 2015-12-07 04:08:46]

https://codereview.chromium.org/1370923002/diff/360001/content/child/blink_pl...
File content/child/blink_platform_impl.h (right):

https://codereview.chromium.org/1370923002/diff/360001/content/child/blink_pl...
content/child/blink_platform_impl.h:135: virtual TraceEventHandle addTraceEvent(
On 2015/12/07 03:58:55, Nico wrote:
> Hm, I suppose this was supposed to be an override too? If it isn't, can it go
> away?

Maybe it's virtual because someone overrides it? This isn't my code, and even
the obvious errors can be traps that I don't want to risk falling into. :(

When I first enforced OVERRIDE, there were dozens of these cases. I left them.
Eventually they got cleaned up...

Right now I want to switch on override enforcement. If the owner wants to come
in and clean things up, they can.

[Nico, 2015-12-07 04:14:52]

Sure, sounds good, but maybe you could check who wrote that line and shoot them
a short "hey while hacking on that thing I noticed that function foo() looks a
bit like a left-over…I thought I'd tell you and maybe this is interesting to
you. Do with this information what you will" kind of mail.

[Avi (use Gerrit), 2015-12-07 15:10:48]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-12-07 15:11:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/360001

[commit-bot: I haz the power, 2015-12-07 15:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 15:21:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Avi (use Gerrit), 2015-12-07 15:25:43]

Description was changed from

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org
==========

[Avi (use Gerrit), 2015-12-07 15:25:51]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-12-07 15:26:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/360001

[commit-bot: I haz the power, 2015-12-07 15:35:10]

Description was changed from

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org
==========

to

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org
==========

[commit-bot: I haz the power, 2015-12-07 15:35:11]

Committed patchset #19 (id:360001)

[commit-bot: I haz the power, 2015-12-07 15:35:59]

Description was changed from

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org
==========

to

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}
==========

[commit-bot: I haz the power, 2015-12-07 15:36:01]

Patchset 19 (id:??) landed as
https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}

[Avi (use Gerrit), 2015-12-07 16:09:19]

A revert of this CL (patchset #19 id:360001) has been created in
https://codereview.chromium.org/1504913002/ by avi@chromium.org.

The reason for reverting is: Missed one..

[Avi (use Gerrit), 2015-12-07 16:18:47]

Description was changed from

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}
==========

to

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}
==========

[Avi (use Gerrit), 2015-12-07 16:21:06]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2015-12-07 16:21:10]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1370923002/#ps380001
(title: "missed one")

[commit-bot: I haz the power, 2015-12-07 16:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370923002/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370923002/380001

[commit-bot: I haz the power, 2015-12-07 20:21:09]

Description was changed from

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}
==========

to

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}
==========

[commit-bot: I haz the power, 2015-12-07 20:21:10]

Committed patchset #20 (id:380001)

[commit-bot: I haz the power, 2015-12-07 20:21:15]

Description was changed from

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}
==========

to

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
R=thakis@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}

Committed: https://crrev.com/09b359e586c35cf06a985dcf326a31aea4a1c6db
Cr-Commit-Position: refs/heads/master@{#363564}
==========

[commit-bot: I haz the power, 2015-12-07 20:21:16]

Patchset 20 (id:??) landed as
https://crrev.com/09b359e586c35cf06a985dcf326a31aea4a1c6db
Cr-Commit-Position: refs/heads/master@{#363564}

[Avi (use Gerrit), 2015-12-07 20:21:51]

Description was changed from

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
R=thakis@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}

Committed: https://crrev.com/09b359e586c35cf06a985dcf326a31aea4a1c6db
Cr-Commit-Position: refs/heads/master@{#363564}
==========

to

==========
Enforce marking "override" for functions overriding Blink.

BUG=535367
TEST=it all stays working
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
R=thakis@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/32ff552858e014d454ce8b181f5aca1dfcf8f8fd
Cr-Commit-Position: refs/heads/master@{#363482}

Committed:
https://chromium.googlesource.com/chromium/src/+/09b359e586c35cf06a985dcf326a...
==========

[Avi (use Gerrit), 2015-12-07 20:21:54]

Committed patchset #20 (id:380001) manually as
09b359e586c35cf06a985dcf326a31aea4a1c6db (presubmit successful).

[Avi (use Gerrit), 2015-12-07 20:22:31]

On 2015/12/07 20:21:54, Avi wrote:
> Committed patchset #20 (id:380001) manually as
> 09b359e586c35cf06a985dcf326a31aea4a1c6db (presubmit successful).

Whatevs, commit queue.