Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: build/config/clang/BUILD.gn

Issue 1370923002: Enforce marking "override" for functions overriding Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed one Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | cc/blink/web_scroll_offset_animation_curve_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("clang.gni") 5 import("clang.gni")
6 6
7 config("find_bad_constructs") { 7 config("find_bad_constructs") {
8 if (clang_use_chrome_plugins) { 8 if (clang_use_chrome_plugins) {
9 cflags = [] 9 cflags = []
10 10
(...skipping 22 matching lines...) Expand all
33 33
34 cflags += [ 34 cflags += [
35 "-Xclang", 35 "-Xclang",
36 "-add-plugin", 36 "-add-plugin",
37 "-Xclang", 37 "-Xclang",
38 "find-bad-constructs", 38 "find-bad-constructs",
39 "-Xclang", 39 "-Xclang",
40 "-plugin-arg-find-bad-constructs", 40 "-plugin-arg-find-bad-constructs",
41 "-Xclang", 41 "-Xclang",
42 "check-templates", 42 "check-templates",
43 "-Xclang",
44 "-plugin-arg-find-bad-constructs",
45 "-Xclang",
46 "enforce-overriding-blink",
43 ] 47 ]
44 } 48 }
45 } 49 }
46 50
47 # Enables some extra Clang-specific warnings. Some third-party code won't 51 # Enables some extra Clang-specific warnings. Some third-party code won't
48 # compile with these so may want to remove this config. 52 # compile with these so may want to remove this config.
49 config("extra_warnings") { 53 config("extra_warnings") {
50 cflags = [ 54 cflags = [
51 "-Wheader-hygiene", 55 "-Wheader-hygiene",
52 56
53 # Warns when a const char[] is converted to bool. 57 # Warns when a const char[] is converted to bool.
54 "-Wstring-conversion", 58 "-Wstring-conversion",
55 ] 59 ]
56 } 60 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | cc/blink/web_scroll_offset_animation_curve_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698