build/common.gypi - Issue 1370923002: Enforce marking "override" for functions overriding Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1370923002: Enforce marking "override" for functions overriding Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed one Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 544f964119ca7f05c418a90d409233c0bd354873..6b2cb0a6db8829ef1af44dff50ee265aebc5bdba 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2227,7 +2227,8 @@

'clang_dynlib_flags%': '',

}],

- 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates ',

+ 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates '

+ '-Xclang -plugin-arg-find-bad-constructs -Xclang enforce-overriding-blink ',

# If you change these, also change build/config/clang/BUILD.gn.

'clang_chrome_plugins_flags%':

« no previous file with comments | « android_webview/renderer/aw_content_settings_client.h ('k') | build/config/clang/BUILD.gn » ('j') | no next file with comments »