Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Unified Diff: content/child/service_worker/service_worker_dispatcher_unittest.cc

Issue 1370923002: Enforce marking "override" for functions overriding Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed one Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/blink_platform_impl.h ('k') | content/child/webthemeengine_impl_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_dispatcher_unittest.cc
diff --git a/content/child/service_worker/service_worker_dispatcher_unittest.cc b/content/child/service_worker/service_worker_dispatcher_unittest.cc
index 5df0501c326148a3faa3dfbb91b51e537c35f918..93d9465c39de69d8ff65cfee4f6cca1f3a529822 100644
--- a/content/child/service_worker/service_worker_dispatcher_unittest.cc
+++ b/content/child/service_worker/service_worker_dispatcher_unittest.cc
@@ -116,13 +116,13 @@ class MockWebServiceWorkerProviderClientImpl
dispatcher_->AddProviderClient(provider_id, this);
}
- ~MockWebServiceWorkerProviderClientImpl() {
+ ~MockWebServiceWorkerProviderClientImpl() override {
dispatcher_->RemoveProviderClient(provider_id_);
}
void setController(
blink::WebPassOwnPtr<blink::WebServiceWorker::Handle> handle,
- bool shouldNotifyControllerChange) {
+ bool shouldNotifyControllerChange) override {
// WebPassOwnPtr cannot be owned in Chromium, so drop the handle here.
// The destruction releases ServiceWorkerHandleReference.
is_set_controlled_called_ = true;
« no previous file with comments | « content/child/blink_platform_impl.h ('k') | content/child/webthemeengine_impl_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698