content/renderer/render_frame_impl.h - Issue 1370923002: Enforce marking "override" for functions overriding Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1370923002: Enforce marking "override" for functions overriding Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed one Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index c357ff81443b41f2784d03dd80d9ea9275128282..baed47f7683970358184e5ef6436c621b47abb88 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -432,7 +432,7 @@ class CONTENT_EXPORT RenderFrameImpl

const blink::WebString& name) override;

void didChangeSandboxFlags(blink::WebFrame* child_frame,

blink::WebSandboxFlags flags) override;

- virtual void didChangeFrameOwnerProperties(

+ void didChangeFrameOwnerProperties(

blink::WebFrame* child_frame,

const blink::WebFrameOwnerProperties& frame_owner_properties) override;

void didMatchCSS(

« no previous file with comments | « content/renderer/media/canvas_capture_handler.h ('k') | content/renderer/vr/vr_dispatcher.h » ('j') | no next file with comments »