Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees (Closed)

Created:
5 years, 2 months ago by tsergeant
Modified:
5 years, 2 months ago
Reviewers:
raymes
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material PDF: Drastically reduce time required to stamp complex bookmark trees The behaviour of dom-if changed in Polymer 1.0 to make it useful for lazily stamping complex DOM subtrees. This CL adds dom-if to viewer-bookmark, so that child bookmarks are only created when they are made visible. On my workstation, this cuts the time to initially render a complex bookmarks menu from 6 seconds to 0.2 seconds. Also, make use of reflectToAttribute to remove some single-use CSS classes. BUG=110020 Committed: https://crrev.com/6c47f50421211570b7549062d199b24a4cf26445 Cr-Commit-Position: refs/heads/master@{#351017}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
tsergeant
PTAL! dom-if is a really impressive performance win here for what is essentially a 2-line ...
5 years, 2 months ago (2015-09-28 01:03:17 UTC) #2
raymes
lgtm
5 years, 2 months ago (2015-09-28 02:54:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369163002/1
5 years, 2 months ago (2015-09-28 03:17:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 03:22:39 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 03:23:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c47f50421211570b7549062d199b24a4cf26445
Cr-Commit-Position: refs/heads/master@{#351017}

Powered by Google App Engine
This is Rietveld 408576698