chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js - Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html ('k') | chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

index 0f6a593c7920626b69df854de544f29a5518af38..694cbbe0a102f20d69d70d816e260e19d8353232 100644

--- a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

+++ b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js

@@ -28,8 +28,9 @@

childDepth: Number,

- childrenShown_: {

+ childrenShown: {

type: Boolean,

+ reflectToAttribute: true,

value: false

}

@@ -50,11 +51,7 @@

toggleChildren: function(e) {

- this.childrenShown_ = !this.childrenShown_;

- if (this.childrenShown_)

- this.$.expand.classList.add('open');

- else

- this.$.expand.classList.remove('open');

+ this.childrenShown = !this.childrenShown;

e.stopPropagation(); // Prevent the above onClick handler from firing.

}

});