chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html - Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.css ('k') | chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styl es.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styl es.html">

4	4

5 <dom-module id="viewer-bookmark" attributes="bookmark">	5 <dom-module id="viewer-bookmark" attributes="bookmark">

6 <link rel="import" type="css" href="viewer-bookmark.css">	6 <link rel="import" type="css" href="viewer-bookmark.css">

7 <template>	7 <template>

8 <div id="item" on-click="onClick">	8 <div id="item" on-click="onClick">

9 <paper-ripple></paper-ripple>	9 <paper-ripple></paper-ripple>

10 <iron-icon id="expand" icon="chevron-right" on-click="toggleChildren">	10 <iron-icon id="expand" icon="chevron-right" on-click="toggleChildren">

11 </iron-icon>	11 </iron-icon>

12 <span id="title">{{bookmark.title}}</span>	12 <span id="title">{{bookmark.title}}</span>

13 </div>	13 </div>

14 <div class="sub-bookmark" hidden$="{{!childrenShown_}}">	14 <!-- dom-if will stamp the complex bookmark tree lazily as individual nodes

15 <!-- The sub-bookmarks will only be created after the parent bookmark has	15 are opened. -->

16 finished initializing and childDepth is available. -->	16 <template is="dom-if" if="{{childrenShown}}" id="sub-bookmarks">

17 <template is="dom-repeat" items="{{bookmark.children}}">	17 <template is="dom-repeat" items="{{bookmark.children}}">

18 <viewer-bookmark bookmark="{{item}}" depth="{{childDepth}}">	18 <viewer-bookmark bookmark="{{item}}" depth="{{childDepth}}">

19 </viewer-bookmark>	19 </viewer-bookmark>

20 </template>	20 </template>

21 </div>	21 </template>

22 </template>	22 </template>

23 </dom-module>	23 </dom-module>

24 <script src="viewer-bookmark.js"></script>	24 <script src="viewer-bookmark.js"></script>

OLD	NEW