chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html - Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.css ('k') | chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

diff --git a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

index 32b1d75dcc4d4f118c728710323a3f7dc65cab36..d40791f3dc9935e21f6d4ad897bec4360ad20a0f 100644

--- a/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

+++ b/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html

@@ -11,14 +11,14 @@

</iron-icon>

<span id="title">{{bookmark.title}}</span>

</div>

- <div class="sub-bookmark" hidden$="{{!childrenShown_}}">

- <!-- The sub-bookmarks will only be created after the parent bookmark has

- finished initializing and childDepth is available. -->

+ <!-- dom-if will stamp the complex bookmark tree lazily as individual nodes

+ are opened. -->

+ <template is="dom-if" if="{{childrenShown}}" id="sub-bookmarks">

<viewer-bookmark bookmark="{{item}}" depth="{{childDepth}}">

</viewer-bookmark>

</template>

- </div>

+ </template>

</template>

</dom-module>