chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js - Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js

Issue 1369163002: Material PDF: Drastically reduce time required to stamp complex bookmark trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css ('k') | chrome/test/data/pdf/material_elements_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js b/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js

index 165a511e16d8bea7a46fc2b456f6b7289d8fdf53..17a04c04d7b682b264c367de0e35cea3b8084643 100644

--- a/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js

+++ b/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.js

@@ -30,6 +30,7 @@

/** True if the dropdown is currently open. */

dropdownOpen: {

type: Boolean,

+ reflectToAttribute: true,

value: false

@@ -69,12 +70,9 @@

toggleDropdown: function() {

this.dropdownOpen = !this.dropdownOpen;

if (this.dropdownOpen) {

- this.$.icon.classList.add('open');

this.$.dropdown.style.display = 'block';

if (!this.maxHeightValid_)

this.updateMaxHeight();

- } else {

- this.$.icon.classList.remove('open');

}

this.cancelAnimation_();

this.playAnimation_(this.dropdownOpen);