Issue 13560007: Remove ARM support for soft float (pre-VFP2)

Issue 13560007: Remove ARM support for soft float (pre-VFP2) (Closed)

Created:
7 years, 8 months ago by danno

Modified:
7 years, 8 months ago

Reviewers:
Rodolph Perfetta, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove ARM support for VFP2 R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14159

Patch Set 3 : Review feedback #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+672 lines, -1726 lines)			Patch
M	src/arm/assembler-arm.h	View	1	3 chunks	+0 lines, -5 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View		40 chunks	+14 lines, -61 lines	0 comments	Download
M	src/arm/assembler-arm-inl.h	View		1 chunk	+3 lines, -15 lines	0 comments	Download
M	src/arm/code-stubs-arm.h	View	1 2	3 chunks	+1 line, -5 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 2	40 chunks	+269 lines, -640 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View		6 chunks	+4 lines, -22 lines	0 comments	Download
M	src/arm/deoptimizer-arm.cc	View		3 chunks	+30 lines, -41 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 2	2 chunks	+22 lines, -37 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 2	1 chunk	+1 line, -10 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2	36 chunks	+36 lines, -229 lines	0 comments	Download
M	src/arm/lithium-gap-resolver-arm.cc	View		5 chunks	+2 lines, -9 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 2	1 chunk	+6 lines, -14 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 2	16 chunks	+11 lines, -96 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 2	6 chunks	+74 lines, -322 lines	0 comments	Download
M	src/assembler.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/code-stubs.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View	1 2	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-linux.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/v8globals.h	View	1 2	1 chunk	+4 lines, -5 lines	0 comments	Download
M	test/cctest/test-assembler-arm.cc	View		3 chunks	+190 lines, -202 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Rodolph Perfetta

https://codereview.chromium.org/13560007/diff/2002/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/13560007/diff/2002/src/arm/code-stubs-arm.cc#newcode1426 src/arm/code-stubs-arm.cc:1426: } else { This was the else from CpuFeatures::IsSupported(VFP2) ...

7 years, 8 months ago (2013-04-04 15:30:04 UTC) #3

Yang

LGTM once Rodolphs comments are addressed. I did not find further mistakes. https://codereview.chromium.org/13560007/diff/2002/src/flag-definitions.h File src/flag-definitions.h ...

7 years, 8 months ago (2013-04-05 10:07:01 UTC) #4

danno

Committed patchset #3 manually as r14159 (presubmit successful).

7 years, 8 months ago (2013-04-07 04:34:47 UTC) #5

danno

7 years, 8 months ago (2013-04-08 19:45:33 UTC) #6

Message was sent while issue was closed.

Feedback addressed, landed.

https://codereview.chromium.org/13560007/diff/2002/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/13560007/diff/2002/src/arm/code-stubs-arm.cc#...
src/arm/code-stubs-arm.cc:1426: } else {
On 2013/04/04 15:30:04, Rodolph Perfetta wrote:
> This was the else from CpuFeatures::IsSupported(VFP2) so it should be removed.

Done.

https://codereview.chromium.org/13560007/diff/2002/src/arm/macro-assembler-ar...
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/13560007/diff/2002/src/arm/macro-assembler-ar...
src/arm/macro-assembler-arm.cc:2537: void
MacroAssembler::ECMAToInt32NoVFP(Register result,
On 2013/04/04 15:30:04, Rodolph Perfetta wrote:
> This should be removed too.

Done.

https://codereview.chromium.org/13560007/diff/2002/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

https://codereview.chromium.org/13560007/diff/2002/src/arm/stub-cache-arm.cc#...
src/arm/stub-cache-arm.cc:974: static void StoreIntAsFloat(MacroAssembler* masm,
On 2013/04/04 15:30:04, Rodolph Perfetta wrote:
> fval and scratch2 are not used anymore, the compiler should complain.

Done.

https://codereview.chromium.org/13560007/diff/2002/src/arm/stub-cache-arm.cc#...
src/arm/stub-cache-arm.cc:3260: 
On 2013/04/04 15:30:04, Rodolph Perfetta wrote:
> the if (elements_kind == EXTERNAL_FLOAT_ELEMENTS) should end here, not after
the
> Ret().

Done.

https://codereview.chromium.org/13560007/diff/2002/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/13560007/diff/2002/src/flag-definitions.h#new...
src/flag-definitions.h:315: "requirement for V8 on ARM")
On 2013/04/05 10:07:01, Yang wrote:
> Not sure why we don't just remove this flag. Specifying an non-existing flag
> doesn't break anything, so it would stay backward-compatible.
> 
> If you want to make it a warning for embedders or something, you could put an
> ASSERT(FLAG_enable_vfp2) somewhere.

Done.

Expand Messages | Collapse Messages