Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1354703002: Delete dead code related to the removed helper apps. (Closed)

Created:
5 years, 3 months ago by Greg K
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete dead code related to the removed helper apps. It is no longer clear if we will be adding more helper variants in the near future. This change removes any additional dead code related to the helper apps. BUG=520680 Committed: https://crrev.com/0c619649467faa44c72db1ddfabbf59e535b4d31 Cr-Commit-Position: refs/heads/master@{#349970}

Patch Set 1 #

Patch Set 2 : Remove verify_no_objc.sh as well #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -315 lines) Patch
D build/mac/make_more_helpers.sh View 1 chunk +0 lines, -84 lines 0 comments Download
D build/mac/verify_no_objc.sh View 1 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +6 lines, -21 lines 2 comments Download
M chrome/chrome.gyp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_process_util.cc View 2 chunks +5 lines, -38 lines 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 1 chunk +0 lines, -9 lines 0 comments Download
M content/content_shell.gypi View 1 2 chunks +0 lines, -32 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Greg K
Mark, would you please review?
5 years, 3 months ago (2015-09-17 23:26:40 UTC) #2
Mark Mentovai
LGTM https://codereview.chromium.org/1354703002/diff/20001/chrome/browser/memory_details_mac.cc File chrome/browser/memory_details_mac.cc (right): https://codereview.chromium.org/1354703002/diff/20001/chrome/browser/memory_details_mac.cc#newcode213 chrome/browser/memory_details_mac.cc:213: // Get PIDs of the helper. The comment ...
5 years, 3 months ago (2015-09-17 23:48:29 UTC) #3
Greg K
derat@chromium.org: Please review changes in app_shell.gyp thestig@chromium.org: Please review changes in chrome/browser/memory_details_mac.cc chrome/chrome.gyp chrome/common/chrome_constants.h chrome/common/chrome_constants.cc ...
5 years, 3 months ago (2015-09-18 16:59:07 UTC) #5
Daniel Erat
rubber-stamp lgtm for extensions/ if it still builds (i don't have any history with the ...
5 years, 3 months ago (2015-09-18 17:01:19 UTC) #6
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-18 17:36:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354703002/20001
5 years, 3 months ago (2015-09-21 17:37:43 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 18:40:04 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:40:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c619649467faa44c72db1ddfabbf59e535b4d31
Cr-Commit-Position: refs/heads/master@{#349970}

Powered by Google App Engine
This is Rietveld 408576698