Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: extensions/shell/app_shell.gyp

Issue 1354703002: Delete dead code related to the removed helper apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove verify_no_objc.sh as well Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/memory_details_mac.cc ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/app_shell.gyp
diff --git a/extensions/shell/app_shell.gyp b/extensions/shell/app_shell.gyp
index 9c6ead50705836643ad84228b58ecdb6102df1b4..0ad524cc6b0f973188b000b5959ec8d26828d4b5 100644
--- a/extensions/shell/app_shell.gyp
+++ b/extensions/shell/app_shell.gyp
@@ -179,30 +179,6 @@
'--scm=1',
'--version=<(app_shell_version)'],
},
- {
- # This postbuild step is responsible for creating the following
- # helpers:
- #
- # App Shell Helper EH.app and App Shell Helper NP.app are
- # created from App Shell Helper.app.
- #
- # The EH helper is marked for an executable heap. The NP helper
- # is marked for no PIE (ASLR).
- 'postbuild_name': 'Make More Helpers',
- 'action': [
- '../../build/mac/make_more_helpers.sh',
- 'Frameworks',
- '<(app_shell_product_name)',
- ],
- },
- {
- # Make sure there isn't any Objective-C in the shell's
- # executable.
- 'postbuild_name': 'Verify No Objective-C',
- 'action': [
- '../../build/mac/verify_no_objc.sh',
- ],
- },
],
}],
],
@@ -416,14 +392,6 @@
'--scm=0',
'--version=<(app_shell_version)'],
},
- {
- # Make sure there isn't any Objective-C in the helper app's
- # executable.
- 'postbuild_name': 'Verify No Objective-C',
- 'action': [
- '../../build/mac/verify_no_objc.sh',
- ],
- },
],
}, # target app_shell_helper
],
« chrome/browser/memory_details_mac.cc ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698