Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/chrome_exe.gypi

Issue 1354703002: Delete dead code related to the removed helper apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove verify_no_objc.sh as well Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'chrome', 8 'target_name': 'chrome',
9 'type': 'none', 9 'type': 'none',
10 'dependencies': [ 'chrome_initial', ], 10 'dependencies': [ 'chrome_initial', ],
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 '--scm=1', 345 '--scm=1',
346 '--bundle_id=<(mac_bundle_id)'], 346 '--bundle_id=<(mac_bundle_id)'],
347 }, 347 },
348 { 348 {
349 'postbuild_name': 'Clean up old versions', 349 'postbuild_name': 'Clean up old versions',
350 'action': [ 350 'action': [
351 'tools/build/mac/clean_up_old_versions', 351 'tools/build/mac/clean_up_old_versions',
352 '<(version_full)' 352 '<(version_full)'
353 ], 353 ],
354 }, 354 },
355 {
356 # This postbuid step is responsible for creating the following
357 # helpers:
358 #
359 # Currently no helpers are produced (crbug.com/520680), but
360 # more will be added soon (crbug.com/497190).
361 #
362 # Normally, applications shipping as part of offical builds with
363 # Google Chrome branding have dsymutil (dwarf-with-dsym,
364 # mac_real_dsym) and dump_syms (mac_breakpad) run on them to
365 # produce a .dSYM bundle and a Breakpad .sym file. This is
366 # unnecessary for the "More Helpers" because they're identical
367 # to the original helper except for the bits in their Mach-O
368 # headers that change to enable or disable special features.
369 # Each .dSYM is identified by UUID stored in a Mach-O file's
370 # LC_UUID load command. Because the "More Helpers" share a UUID
371 # with the original helper, there's no need to run dsymutil
372 # again. All helpers can share the same .dSYM. Special handling
373 # is performed in chrome/tools/build/mac/dump_product_syms to
374 # prepare their Breakpad symbol files.
375 'postbuild_name': 'Make More Helpers',
376 'action': [
377 '../build/mac/make_more_helpers.sh',
378 'Versions/<(version_full)',
379 '<(mac_product_name)',
380 ],
381 },
382 {
383 # Make sure there isn't any Objective-C in the browser app's
384 # executable.
385 'postbuild_name': 'Verify No Objective-C',
386 'action': [
387 '../build/mac/verify_no_objc.sh',
388 ],
389 },
390 ], # postbuilds 355 ], # postbuilds
391 }, { # OS != "mac" 356 }, { # OS != "mac"
392 'conditions': [ 357 'conditions': [
393 # TODO: add a: 358 # TODO: add a:
394 # 'product_name': 'chromium' 359 # 'product_name': 'chromium'
395 # whenever we convert the rest of the infrastructure 360 # whenever we convert the rest of the infrastructure
396 # (buildbots etc.) to understand the branding gyp define. 361 # (buildbots etc.) to understand the branding gyp define.
397 # NOTE: chrome/app/theme/chromium/BRANDING and 362 # NOTE: chrome/app/theme/chromium/BRANDING and
398 # chrome/app/theme/google_chrome/BRANDING have the short name 363 # chrome/app/theme/google_chrome/BRANDING have the short name
399 # "chrome" etc.; should we try to extract from there instead? 364 # "chrome" etc.; should we try to extract from there instead?
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 'dependencies': [ 617 'dependencies': [
653 'chrome_nacl_win64', 618 'chrome_nacl_win64',
654 ], 619 ],
655 }], 620 }],
656 ], 621 ],
657 }, 622 },
658 ], 623 ],
659 }], 624 }],
660 ], 625 ],
661 } 626 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698