Delete dead code related to the removed helper apps.

chrome/browser/memory_details_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/memory_details.h"
 
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 192 matching lines @@
   for (size_t index = CHROME_BROWSER; index < MAX_BROWSERS; index++) {
     base::NamedProcessIterator process_it(
         base::UTF16ToUTF8(process_data_[index].process_name), NULL);
 
     while (const base::ProcessEntry* entry = process_it.NextProcessEntry()) {
       pids_by_browser[index].push_back(entry->pid());
       all_pids.push_back(entry->pid());
     }
   }
 
-  // The helper might show up as these different flavors depending on the
-  // executable flags required.
-  std::vector<std::string> helper_names;
-  helper_names.push_back(chrome::kHelperProcessExecutableName);
-  for (const char* const* suffix = chrome::kHelperFlavorSuffixes;
-       *suffix;
-       ++suffix) {
-    std::string helper_name = chrome::kHelperProcessExecutableName;
-    helper_name.append(1, ' ');
-    helper_name.append(*suffix);
-    helper_names.push_back(helper_name);
-  }
-
-  // Get PIDs of helpers.
+  // Get PIDs of the helper.

[Mark Mentovai, 2015/09/17 23:48:29]

The comment was correct before, “helpers,” because many helper processes appear,
even if they all come from the same executable.

   std::vector<base::ProcessId> helper_pids;
-  for (size_t i = 0; i < helper_names.size(); ++i) {
-    std::string helper_name = helper_names[i];
-    base::NamedProcessIterator helper_it(helper_name, NULL);
-    while (const base::ProcessEntry* entry = helper_it.NextProcessEntry()) {
-      helper_pids.push_back(entry->pid());
-      all_pids.push_back(entry->pid());
-    }
+  base::NamedProcessIterator helper_it(chrome::kHelperProcessExecutableName,
+                                       NULL);

[Mark Mentovai, 2015/09/17 23:48:29]

Use nullptr in new code.

+  while (const base::ProcessEntry* entry = helper_it.NextProcessEntry()) {
+    helper_pids.push_back(entry->pid());
+    all_pids.push_back(entry->pid());
   }
 
   if (mode == FROM_ALL_BROWSERS) {
     CollectProcessDataAboutNonChromeProcesses(all_pids, pids_by_browser,
                                               &process_data_);
   }
 
   ProcessMemoryInformationList* chrome_processes =
       &process_data_[CHROME_BROWSER].processes;
 
   // Collect data about Chrome/Chromium.
   for (const base::ProcessId& pid : pids_by_browser[CHROME_BROWSER])
     CollectProcessDataForChromeProcess(child_info, pid, chrome_processes);
 
   // And collect data about the helpers.
   for (const base::ProcessId& pid : helper_pids)
     CollectProcessDataForChromeProcess(child_info, pid, chrome_processes);
 
   // Finally return to the browser thread.
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&MemoryDetails::CollectChildInfoOnUIThread, this));
 }