Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/chrome_exe.gypi

Issue 1354703002: Delete dead code related to the removed helper apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove verify_no_objc.sh as well Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 5d6ed4ea721ec1dc6cd876debf46ba33b26d1655..adc8893cba9d2ac4baa3ca3c9be6f78124f45a79 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -352,41 +352,6 @@
'<(version_full)'
],
},
- {
- # This postbuid step is responsible for creating the following
- # helpers:
- #
- # Currently no helpers are produced (crbug.com/520680), but
- # more will be added soon (crbug.com/497190).
- #
- # Normally, applications shipping as part of offical builds with
- # Google Chrome branding have dsymutil (dwarf-with-dsym,
- # mac_real_dsym) and dump_syms (mac_breakpad) run on them to
- # produce a .dSYM bundle and a Breakpad .sym file. This is
- # unnecessary for the "More Helpers" because they're identical
- # to the original helper except for the bits in their Mach-O
- # headers that change to enable or disable special features.
- # Each .dSYM is identified by UUID stored in a Mach-O file's
- # LC_UUID load command. Because the "More Helpers" share a UUID
- # with the original helper, there's no need to run dsymutil
- # again. All helpers can share the same .dSYM. Special handling
- # is performed in chrome/tools/build/mac/dump_product_syms to
- # prepare their Breakpad symbol files.
- 'postbuild_name': 'Make More Helpers',
- 'action': [
- '../build/mac/make_more_helpers.sh',
- 'Versions/<(version_full)',
- '<(mac_product_name)',
- ],
- },
- {
- # Make sure there isn't any Objective-C in the browser app's
- # executable.
- 'postbuild_name': 'Verify No Objective-C',
- 'action': [
- '../build/mac/verify_no_objc.sh',
- ],
- },
], # postbuilds
}, { # OS != "mac"
'conditions': [

Powered by Google App Engine
This is Rietveld 408576698