Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13529026: Removing a bunch of unused platform code. (Closed)

Created:
7 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 8 months ago
CC:
blink-reviews, Stephen Chennney, Nate Chapin, abarth-chromium
Visibility:
Public.

Description

Removing a bunch of unused platform code. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147707

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix whitespace and compiler error on Mac. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3937 lines) Patch
M Source/JavaScriptCore/config.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WTF/WTF.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WTF/config.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WTF/wtf/Assertions.cpp View 1 chunk +2 lines, -8 lines 0 comments Download
D Source/WTF/wtf/DisallowCType.h View 1 chunk +0 lines, -84 lines 0 comments Download
M Source/WTF/wtf/FastMalloc.cpp View 5 chunks +1 line, -18 lines 0 comments Download
M Source/WTF/wtf/FeatureDefines.h View 1 1 chunk +0 lines, -185 lines 0 comments Download
M Source/WTF/wtf/PassRefPtr.h View 1 chunk +2 lines, -12 lines 0 comments Download
M Source/WTF/wtf/Platform.h View 1 1 chunk +1 line, -22 lines 0 comments Download
M Source/WTF/wtf/ThreadingPthreads.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WTF/wtf/text/AtomicString.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/WTF/wtf/text/StringImpl.h View 6 chunks +0 lines, -44 lines 0 comments Download
M Source/WTF/wtf/text/StringImpl.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M Source/WTF/wtf/text/WTFString.h View 3 chunks +0 lines, -38 lines 0 comments Download
M Source/WTF/wtf/text/WTFString.cpp View 1 chunk +1 line, -15 lines 0 comments Download
M Source/WebCore/accessibility/AccessibilityObject.h View 3 chunks +0 lines, -61 lines 0 comments Download
M Source/WebCore/accessibility/AccessibilityObject.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/WebCore/config.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/history/HistoryItem.h View 4 chunks +0 lines, -25 lines 0 comments Download
M Source/WebCore/html/HTMLCanvasElement.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/WebCore/html/HTMLFormControlElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/html/HTMLObjectElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp View 3 chunks +0 lines, -24 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasStyle.cpp View 3 chunks +0 lines, -19 lines 0 comments Download
M Source/WebCore/html/canvas/WebGLContextGroup.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/loader/FTPDirectoryParser.cpp View 2 chunks +2 lines, -36 lines 0 comments Download
M Source/WebCore/loader/icon/IconDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/ContextMenuController.cpp View 12 chunks +0 lines, -59 lines 0 comments Download
M Source/WebCore/page/EventHandler.cpp View 3 chunks +0 lines, -14 lines 0 comments Download
M Source/WebCore/page/Settings.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/WebCore/page/Settings.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M Source/WebCore/platform/ContextMenu.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/ContextMenuItem.h View 3 chunks +0 lines, -41 lines 0 comments Download
M Source/WebCore/platform/Cursor.h View 5 chunks +0 lines, -39 lines 0 comments Download
M Source/WebCore/platform/DragImage.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/platform/FileSystem.h View 1 4 chunks +3 lines, -51 lines 0 comments Download
M Source/WebCore/platform/LocalizedStrings.h View 6 chunks +0 lines, -84 lines 0 comments Download
M Source/WebCore/platform/LocalizedStrings.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/WebCore/platform/MIMETypeRegistry.cpp View 6 chunks +0 lines, -126 lines 0 comments Download
M Source/WebCore/platform/NotImplemented.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/WebCore/platform/Pasteboard.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/platform/PlatformKeyboardEvent.h View 4 chunks +0 lines, -84 lines 0 comments Download
M Source/WebCore/platform/PlatformMenuDescription.h View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/WebCore/platform/PlatformTouchEvent.h View 2 chunks +0 lines, -31 lines 0 comments Download
M Source/WebCore/platform/PlatformTouchPoint.h View 2 chunks +0 lines, -16 lines 0 comments Download
D Source/WebCore/platform/RunLoop.h View 1 chunk +0 lines, -168 lines 0 comments Download
D Source/WebCore/platform/RunLoop.cpp View 1 chunk +0 lines, -118 lines 0 comments Download
M Source/WebCore/platform/SchemeRegistry.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/ScrollAnimatorNone.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M Source/WebCore/platform/SharedBuffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/platform/SharedBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/Widget.h View 3 chunks +0 lines, -31 lines 0 comments Download
M Source/WebCore/platform/cf/SharedBufferCF.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/ANGLEWebKitBridge.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/BitmapImage.h View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/WebCore/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/Color.h View 2 chunks +0 lines, -28 lines 0 comments Download
M Source/WebCore/platform/graphics/FloatRect.h View 3 chunks +0 lines, -25 lines 0 comments Download
M Source/WebCore/platform/graphics/Font.h View 3 chunks +0 lines, -16 lines 0 comments Download
M Source/WebCore/platform/graphics/FontPlatformData.h View 8 chunks +4 lines, -43 lines 0 comments Download
M Source/WebCore/platform/graphics/GlyphBuffer.h View 3 chunks +0 lines, -16 lines 0 comments Download
M Source/WebCore/platform/graphics/Gradient.h View 3 chunks +2 lines, -7 lines 0 comments Download
M Source/WebCore/platform/graphics/ImageBufferData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/LayoutPoint.h View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/WebCore/platform/graphics/LayoutRect.h View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/WebCore/platform/graphics/LayoutSize.h View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayer.cpp View 4 chunks +1 line, -68 lines 0 comments Download
M Source/WebCore/platform/graphics/NativeImagePtr.h View 3 chunks +0 lines, -10 lines 0 comments Download
M Source/WebCore/platform/graphics/OpenGLShims.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/platform/graphics/OpenGLShims.cpp View 4 chunks +1 line, -21 lines 0 comments Download
M Source/WebCore/platform/graphics/Path.h View 5 chunks +1 line, -26 lines 0 comments Download
M Source/WebCore/platform/graphics/Path.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/Pattern.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/platform/graphics/PlatformLayer.h View 1 chunk +1 line, -31 lines 0 comments Download
M Source/WebCore/platform/graphics/ShadowBlur.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/ShadowBlur.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/WebCore/platform/graphics/SimpleFontData.h View 3 chunks +0 lines, -11 lines 0 comments Download
M Source/WebCore/platform/graphics/WidthIterator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/cg/FloatSizeCG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/cg/IntRectCG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h View 1 chunk +0 lines, -5 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/GLXConfigSelector.h View 1 chunk +0 lines, -211 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/GLXContext.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/GLXContext.cpp View 1 chunk +0 lines, -141 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.h View 1 chunk +0 lines, -85 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp View 1 chunk +0 lines, -286 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp View 1 chunk +0 lines, -486 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/OwnPtrX11.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/X11Helper.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/WebCore/platform/graphics/surfaces/glx/X11Helper.cpp View 1 chunk +0 lines, -309 lines 0 comments Download
M Source/WebCore/platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp View 2 chunks +0 lines, -19 lines 0 comments Download
M Source/WebCore/platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp View 3 chunks +1 line, -19 lines 0 comments Download
M Source/WebCore/platform/graphics/transforms/AffineTransform.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.h View 3 chunks +2 lines, -17 lines 0 comments Download
M Source/WebCore/platform/image-decoders/ImageDecoder.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/mac/SharedBufferMac.mm View 2 chunks +0 lines, -13 lines 0 comments Download
M Source/WebCore/platform/network/NetworkStateNotifier.h View 3 chunks +0 lines, -57 lines 0 comments Download
M Source/WebCore/platform/network/NetworkStateNotifier.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/network/NetworkingContext.h View 2 chunks +0 lines, -20 lines 0 comments Download
M Source/WebCore/platform/network/ResourceHandle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/network/ResourceHandleInternal.h View 3 chunks +0 lines, -22 lines 0 comments Download
M Source/WebCore/platform/network/ResourceRequestBase.cpp View 2 chunks +1 line, -10 lines 0 comments Download
M Source/WebCore/platform/text/TextBoundaries.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/WebCore/rendering/RenderTreeAsText.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
leviw_travelin_and_unemployed
Feel free to wait for the trybots... this one is huge.
7 years, 8 months ago (2013-04-05 22:20:01 UTC) #1
eae
https://codereview.chromium.org/13529026/diff/1/Source/WebCore/loader/archive/ArchiveFactory.cpp File Source/WebCore/loader/archive/ArchiveFactory.cpp (right): https://codereview.chromium.org/13529026/diff/1/Source/WebCore/loader/archive/ArchiveFactory.cpp#newcode34 Source/WebCore/loader/archive/ArchiveFactory.cpp:34: #if USE(CF) && ENABLE(WEB_ARCHIVE) Where did this come from? ...
7 years, 8 months ago (2013-04-05 22:28:53 UTC) #2
Nate Chapin
https://codereview.chromium.org/13529026/diff/1/Source/WebCore/loader/archive/ArchiveFactory.cpp File Source/WebCore/loader/archive/ArchiveFactory.cpp (right): https://codereview.chromium.org/13529026/diff/1/Source/WebCore/loader/archive/ArchiveFactory.cpp#newcode34 Source/WebCore/loader/archive/ArchiveFactory.cpp:34: #if USE(CF) && ENABLE(WEB_ARCHIVE) On 2013/04/05 22:28:53, eae wrote: ...
7 years, 8 months ago (2013-04-05 22:31:02 UTC) #3
leviw_travelin_and_unemployed
https://codereview.chromium.org/13529026/diff/1/Source/WebCore/platform/Pasteboard.h File Source/WebCore/platform/Pasteboard.h (left): https://codereview.chromium.org/13529026/diff/1/Source/WebCore/platform/Pasteboard.h#oldcode76 Source/WebCore/platform/Pasteboard.h:76: Pasteboard(); On 2013/04/05 22:28:53, eae wrote: > This file ...
7 years, 8 months ago (2013-04-05 22:39:18 UTC) #4
eae
LGTM
7 years, 8 months ago (2013-04-05 22:40:06 UTC) #5
leviw_travelin_and_unemployed
Committed patchset #2 manually as r147707 (presubmit successful).
7 years, 8 months ago (2013-04-05 23:47:51 UTC) #6
eseidel
It appears you added back the FTP directory parser by accident.
7 years, 8 months ago (2013-04-05 23:49:14 UTC) #7
leviw_travelin_and_unemployed
7 years, 8 months ago (2013-04-06 01:51:54 UTC) #8
Message was sent while issue was closed. 
On 2013/04/05 23:49:14, Eric Seidel (Google) wrote:
> It appears you added back the FTP directory parser by accident.

D'oh! Thanks for the catch... I really wish we had a pop-up pretty-diff so I
could verify my changes before landing them :-/

Powered by Google App Engine
This is Rietveld 408576698