LayoutTests/paint/selection/invalidation-rect-includes-newline.html - Issue 1350973003: Invalidate line break selection rects when selected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/paint/selection/invalidation-rect-includes-newline.html

Issue 1350973003: Invalidate line break selection rects when selected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Don't need redundant early-out for selection rect. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/paint/selection/invalidation-rect-includes-newline.html

diff --git a/LayoutTests/paint/selection/invalidation-rect-includes-newline.html b/LayoutTests/paint/selection/invalidation-rect-includes-newline.html

index 0dd07e0d331e51287fddc3952b729e6ed048063a..5fed1477371ba78d2bf051bfb4c9682d8a7330d8 100644

--- a/LayoutTests/paint/selection/invalidation-rect-includes-newline.html

+++ b/LayoutTests/paint/selection/invalidation-rect-includes-newline.html

@@ -1,15 +1,11 @@

<!DOCTYPE html>

+<script src="resources/selection.js"></script>

// Selects two lines and expects a newline to be represented.

function repaintTest() {

- if (window.internals)

- window.internals.setSelectionPaintingWithoutSelectionGapsEnabled(true);

- var range = document.createRange();

- range.setStart(container, 0);

- range.setEnd(container, 1);

- window.getSelection().addRange(range);

+ selectRange(container, 0, container, 1);

};

window.onload = runRepaintTest;

</script>

« no previous file with comments | « no previous file | LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline.html » ('j') | no next file with comments »