Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1355913004: Disable newline selection highlighting for vertical and RTL text. (Closed)

Created:
5 years, 3 months ago by wkorman
Modified:
5 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@474759_invalidate_br_and_horiz_only
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Disable newline selection highlighting for vertical and RTL text. BUG=474759 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202563

Patch Set 1 #

Total comments: 2

Patch Set 2 : Disable newline highlighting for RTL. #

Patch Set 3 : Merge changes. #

Messages

Total messages: 12 (5 generated)
wkorman
5 years, 3 months ago (2015-09-18 21:30:24 UTC) #2
chrishtr
https://codereview.chromium.org/1355913004/diff/1/Source/core/layout/line/InlineTextBox.cpp File Source/core/layout/line/InlineTextBox.cpp (right): https://codereview.chromium.org/1355913004/diff/1/Source/core/layout/line/InlineTextBox.cpp#newcode193 Source/core/layout/line/InlineTextBox.cpp:193: && isHorizontal() Only for left-to-right writing mode. RTL is ...
5 years, 3 months ago (2015-09-18 21:34:28 UTC) #3
wkorman
https://codereview.chromium.org/1355913004/diff/1/Source/core/layout/line/InlineTextBox.cpp File Source/core/layout/line/InlineTextBox.cpp (right): https://codereview.chromium.org/1355913004/diff/1/Source/core/layout/line/InlineTextBox.cpp#newcode193 Source/core/layout/line/InlineTextBox.cpp:193: && isHorizontal() On 2015/09/18 at 21:34:28, chrishtr wrote: > ...
5 years, 3 months ago (2015-09-18 22:15:11 UTC) #4
chrishtr
lgtm
5 years, 3 months ago (2015-09-18 22:16:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355913004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355913004/20001
5 years, 3 months ago (2015-09-18 22:17:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355913004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355913004/40001
5 years, 3 months ago (2015-09-19 00:55:32 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 03:13:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202563

Powered by Google App Engine
This is Rietveld 408576698