LayoutTests/paint/selection/text-selection-newline-span.html - Issue 1350973003: Invalidate line break selection rects when selected.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/paint/selection/text-selection-newline-span.html

Issue 1350973003: Invalidate line break selection rects when selected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Don't need redundant early-out for selection rect. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/paint/selection/text-selection-newline-br.html ('k') | LayoutTests/paint/selection/text-selection-newline-span-across-line.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/ahem.js"></script>	4 <script src="../../resources/ahem.js"></script>

5 <script src="../../resources/run-after-layout-and-paint.js"></script>	5 <script src="../../resources/run-after-layout-and-paint.js"></script>

6 <script src="resources/selection.js"></script>	6 <script src="resources/selection.js"></script>

7 <style>	7 <style>

8 div {	8 div {

9 font-family: Ahem;	9 font-family: Ahem;

10 width: 5em;	10 width: 5em;

11 }	11 }

12 </style>	12 </style>

13 </head>	13 </head>

14 <body onload="selectRange(container, 0, container, 3);">	14 <body onload="selectRangeAfterLayoutAndPaint(container, 0, container, 3);">

15 <!-- Two lines in one block with a span on the first line. Should wrap and	15 <!-- Two lines in one block with a span on the first line. Should wrap and

16 include space representing a newline only at end of the first line. -->	16 include space representing a newline only at end of the first line. -->

17 <div id="container">	17 <div id="container">

18 x <span>y</span> z a	18 x <span>y</span> z a

19 </div>	19 </div>

20 </body>	20 </body>

OLD	NEW