Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: Source/core/layout/LayoutBR.h

Issue 1350973003: Invalidate line break selection rects when selected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Don't need redundant early-out for selection rect. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutBR.h
diff --git a/Source/core/layout/LayoutBR.h b/Source/core/layout/LayoutBR.h
index c7e738fa18e518ed2a529af17c17f95e8d57d872..84b8bb09cc38422f1d216815221170f747766a65 100644
--- a/Source/core/layout/LayoutBR.h
+++ b/Source/core/layout/LayoutBR.h
@@ -36,12 +36,7 @@ public:
const char* name() const override { return "LayoutBR"; }
- LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* /* paintInvalidationContainer */) const override
- {
- // TODO(wkorman): When selected we need to return a rect that includes the
- // space highlighted to illustrate a newline.
- return LayoutRect();
- }
+ LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* /* paintInvalidationContainer */) const override;
float width(unsigned /* from */, unsigned /* len */, const Font&, LayoutUnit /* xpos */, TextDirection, HashSet<const SimpleFontData*>* = nullptr /* fallbackFonts */ , FloatRect* /* glyphBounds */ = nullptr) const override { return 0; }
float width(unsigned /* from */, unsigned /* len */, LayoutUnit /* xpos */, TextDirection, bool = false /* firstLine */, HashSet<const SimpleFontData*>* = nullptr /* fallbackFonts */, FloatRect* /* glyphBounds */ = nullptr) const override { return 0; }
« no previous file with comments | « LayoutTests/paint/selection/text-selection-newline-span-across-line.html ('k') | Source/core/layout/LayoutBR.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698