Cleanup: Pass std::string as const reference from net/

Cleanup: Pass std::string as const reference from net/

Passing std::string by reference can prevent extra copying of object.

BUG=367418
TEST=
R=cbentzel@chromium.org,davidben@chromium.org,mef@chromium.org

Committed: https://crrev.com/144dce1fa66f5ad93e6f6d6cedcdf191d2247ed6
Cr-Commit-Position: refs/heads/master@{#350081}

[cbentzel, 2015-09-21 11:49:15]

On 2015/09/20 20:14:30, ki.stfu wrote:

Mostly looks good, but adding rch for the QUIC changes as we share some of the
code with another repo and it might be easier to make the changes there.

Also: moving from std::string arguments to const-ref seems like a reasonable
change, but most of the code that is changed here is in test code so the
performance implications are pretty small.

[ki.stfu, 2015-09-21 14:55:00]

On 2015/09/21 11:49:15, cbentzel wrote:
> On 2015/09/20 20:14:30, ki.stfu wrote:
> 
> Mostly looks good, but adding rch for the QUIC changes as we share some of the
> code with another repo and it might be easier to make the changes there.
Where is "there"?

[cbentzel, 2015-09-21 17:35:54]

cbentzel@chromium.org changed reviewers:
+ rch@chromium.org

[cbentzel, 2015-09-21 17:36:25]

On 2015/09/21 14:55:00, ki.stfu wrote:
> On 2015/09/21 11:49:15, cbentzel wrote:
> > On 2015/09/20 20:14:30, ki.stfu wrote:
> > 
> > Mostly looks good, but adding rch for the QUIC changes as we share some of
the
> > code with another repo and it might be easier to make the changes there.
> Where is "there"?

"there" is google-internal code base. Actually added rch to the review list for
the quic specific issues.

[Ryan Hamilton, 2015-09-21 22:52:33]

On 2015/09/21 17:36:25, cbentzel wrote:
> On 2015/09/21 14:55:00, ki.stfu wrote:
> > On 2015/09/21 11:49:15, cbentzel wrote:
> > > On 2015/09/20 20:14:30, ki.stfu wrote:
> > > 
> > > Mostly looks good, but adding rch for the QUIC changes as we share some of
> the
> > > code with another repo and it might be easier to make the changes there.
> > Where is "there"?
> 
> "there" is google-internal code base. Actually added rch to the review list
for
> the quic specific issues.

LGTM. I'll make sure we make this change internally too.

[ki.stfu, 2015-09-21 22:56:43]

The CQ bit was checked by ki.stfu@gmail.com

[commit-bot: I haz the power, 2015-09-21 22:57:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1346943004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1346943004/1

[commit-bot: I haz the power, 2015-09-22 01:08:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-22 01:08:37]

Patchset 1 (id:??) landed as
https://crrev.com/144dce1fa66f5ad93e6f6d6cedcdf191d2247ed6
Cr-Commit-Position: refs/heads/master@{#350081}