net/quic/quic_stream_sequencer.h - Issue 1346943004: Cleanup: Pass std::string as const reference from net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_sequencer.h

Issue 1346943004: Cleanup: Pass std::string as const reference from net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_stream_sequencer.h

diff --git a/net/quic/quic_stream_sequencer.h b/net/quic/quic_stream_sequencer.h

index 8a2e4d87c67e9512d1fe39b36d84787fadfc8f7e..60a950b3bcd94459346c8f9ca2f2ae2ec8ea6bbf 100644

--- a/net/quic/quic_stream_sequencer.h

+++ b/net/quic/quic_stream_sequencer.h

@@ -27,7 +27,7 @@ class NET_EXPORT_PRIVATE QuicStreamSequencer {

public:

// A contiguous segment received by a QUIC stream.

struct FrameData {

- FrameData(QuicStreamOffset offset, std::string segment);

+ FrameData(QuicStreamOffset offset, const std::string& segment);

const QuicStreamOffset offset;

std::string segment;

« no previous file with comments | « net/quic/crypto/crypto_server_config_protobuf.h ('k') | net/quic/quic_stream_sequencer.cc » ('j') | no next file with comments »