net/socket/tcp_server_socket_unittest.cc - Issue 1346943004: Cleanup: Pass std::string as const reference from net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_server_socket_unittest.cc

Issue 1346943004: Cleanup: Pass std::string as const reference from net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/tcp_server_socket_unittest.cc

diff --git a/net/socket/tcp_server_socket_unittest.cc b/net/socket/tcp_server_socket_unittest.cc

index 2f6491bf8cf98338899428cdd266aeba7d9935f1..19c715bfc91f84eb783ba20ad55072f592564479 100644

--- a/net/socket/tcp_server_socket_unittest.cc

+++ b/net/socket/tcp_server_socket_unittest.cc

@@ -50,7 +50,9 @@ class TCPServerSocketTest : public PlatformTest {

*success = true;

}

- void ParseAddress(std::string ip_str, uint16 port, IPEndPoint* address) {

+ void ParseAddress(const std::string& ip_str,

+ uint16 port,

+ IPEndPoint* address) {

IPAddressNumber ip_number;

bool rv = ParseIPLiteralToNumber(ip_str, &ip_number);

if (!rv)

« no previous file with comments | « net/quic/quic_stream_sequencer.cc ('k') | net/spdy/spdy_alt_svc_wire_format_test.cc » ('j') | no next file with comments »