net/spdy/spdy_prefixed_buffer_reader_test.cc - Issue 1346943004: Cleanup: Pass std::string as const reference from net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_prefixed_buffer_reader_test.cc

Issue 1346943004: Cleanup: Pass std::string as const reference from net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_prefixed_buffer_reader_test.cc

diff --git a/net/spdy/spdy_prefixed_buffer_reader_test.cc b/net/spdy/spdy_prefixed_buffer_reader_test.cc

index e3a6a6552dc84b3004db8af57cf4f6b1dd321216..406bab71618cefe3198b0caa846b0e4acd46bd06 100644

--- a/net/spdy/spdy_prefixed_buffer_reader_test.cc

+++ b/net/spdy/spdy_prefixed_buffer_reader_test.cc

@@ -16,7 +16,8 @@ using testing::ElementsAreArray;

class SpdyPrefixedBufferReaderTest : public ::testing::Test {

protected:

- SpdyPrefixedBufferReader Build(std::string prefix, std::string suffix) {

+ SpdyPrefixedBufferReader Build(const std::string& prefix,

+ const std::string& suffix) {

prefix_ = prefix;

suffix_ = suffix;

return SpdyPrefixedBufferReader(prefix_.data(), prefix_.length(),

« no previous file with comments | « net/spdy/spdy_pinnable_buffer_piece_test.cc ('k') | net/spdy/spdy_protocol.h » ('j') | no next file with comments »