net/dns/mdns_client_impl.h - Issue 1346943004: Cleanup: Pass std::string as const reference from net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mdns_client_impl.h

Issue 1346943004: Cleanup: Pass std::string as const reference from net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/mdns_client_impl.h

diff --git a/net/dns/mdns_client_impl.h b/net/dns/mdns_client_impl.h

index e788601fd76ec4e608aab43d523370e5f5be8a62..a9234c494a13cf1b686f2492e6184220c2b81460 100644

--- a/net/dns/mdns_client_impl.h

+++ b/net/dns/mdns_client_impl.h

@@ -122,7 +122,7 @@ class NET_EXPORT_PRIVATE MDnsClientImpl : public MDnsClient {

bool Init(MDnsSocketFactory* socket_factory);

// Send a query with a specific rrtype and name. Returns true on success.

- bool SendQuery(uint16 rrtype, std::string name);

+ bool SendQuery(uint16 rrtype, const std::string& name);

// Add/remove a listener to the list of listeners.

void AddListener(MDnsListenerImpl* listener);

« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | net/dns/mdns_client_impl.cc » ('j') | no next file with comments »