Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage

Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage

Adding this parameter lets the same object act as an observer for multiple
RenderFrames.

BUG=329618
TEST=unit,trybot

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244269

[nasko, 2014-01-10 17:26:18]

LGTM with a couple of nits.

https://codereview.chromium.org/134183002/diff/1/chrome/renderer/chrome_conte...
File chrome/renderer/chrome_content_renderer_client_unittest.cc (right):

https://codereview.chromium.org/134183002/diff/1/chrome/renderer/chrome_conte...
chrome/renderer/chrome_content_renderer_client_unittest.cc:399:
EXPECT_FALSE(client.ShouldSuppressErrorPage(NULL, GURL("http://example.com")));
style: exceeds 80 characters

https://codereview.chromium.org/134183002/diff/1/content/public/renderer/cont...
File content/public/renderer/content_renderer_client.h (right):

https://codereview.chromium.org/134183002/diff/1/content/public/renderer/cont...
content/public/renderer/content_renderer_client.h:109: // navigation to |url|.
nit: to |url| in |render_frame|.

[commit-bot: I haz the power, 2014-01-10 18:04:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ellyjones@chromium.org/134183002/40002

[Elly Fong-Jones, 2014-01-10 18:13:41]

jam: ptal?

[jam, 2014-01-10 18:26:44]

lgtm. to be clear, you're going to change the Chrome implementation to use this
extra parameter in the future?

https://codereview.chromium.org/134183002/diff/40002/content/renderer/render_...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/134183002/diff/40002/content/renderer/render_...
content/renderer/render_frame_impl.cc:959: if
(GetContentClient()->renderer()->ShouldSuppressErrorPage(this,
nit: according to style guide, the first parameter on each line should start on
the same column. so move |this| to the next line

[jam, 2014-01-10 18:26:45]

lgtm. to be clear, you're going to change the Chrome implementation to use this
extra parameter in the future?

[Elly Fong-Jones, 2014-01-10 18:33:57]

On 2014/01/10 18:26:45, jam wrote:
> lgtm. to be clear, you're going to change the Chrome implementation to use
this
> extra parameter in the future?

correct.

[commit-bot: I haz the power, 2014-01-10 22:45:37]

Change committed as 244269