chrome/renderer/chrome_content_renderer_client_unittest.cc - Issue 134183002: Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client_unittest.cc

Issue 134183002: Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fix nits Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | content/public/renderer/content_renderer_client.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client_unittest.cc

diff --git a/chrome/renderer/chrome_content_renderer_client_unittest.cc b/chrome/renderer/chrome_content_renderer_client_unittest.cc

index 33739e17d6dd344d05505dea7242dbeb720d0d5a..48aa0fce32307ede42669ab497a8adb8dae6454e 100644

--- a/chrome/renderer/chrome_content_renderer_client_unittest.cc

+++ b/chrome/renderer/chrome_content_renderer_client_unittest.cc

@@ -396,6 +396,8 @@ TEST_F(ChromeContentRendererClientTest, ShouldSuppressErrorPage) {

client.search_bouncer_.reset(new SearchBouncer);

client.search_bouncer_->OnSetSearchURLs(

std::vector<GURL>(), GURL("http://example.com/n"));

- EXPECT_FALSE(client.ShouldSuppressErrorPage(GURL("http://example.com")));

- EXPECT_TRUE(client.ShouldSuppressErrorPage(GURL("http://example.com/n")));

+ EXPECT_FALSE(client.ShouldSuppressErrorPage(NULL,

+ GURL("http://example.com")));

+ EXPECT_TRUE(client.ShouldSuppressErrorPage(NULL,

+ GURL("http://example.com/n")));

}