chrome/renderer/chrome_content_renderer_client.h - Issue 134183002: Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.h

Issue 134183002: Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fix nits Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/chrome_content_renderer_client.h

diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h

index ecc669205410f60161f1c6b79cd08678c9c8e4d2..6668aa3566242ed1fee6e99c61f64f09d8b38c28 100644

--- a/chrome/renderer/chrome_content_renderer_client.h

+++ b/chrome/renderer/chrome_content_renderer_client.h

@@ -81,7 +81,8 @@ class ChromeContentRendererClient : public content::ContentRendererClient {

const base::FilePath& plugin_path) OVERRIDE;

virtual bool HasErrorPage(int http_status_code,

std::string* error_domain) OVERRIDE;

- virtual bool ShouldSuppressErrorPage(const GURL& url) OVERRIDE;

+ virtual bool ShouldSuppressErrorPage(content::RenderFrame* render_frame,

+ const GURL& url) OVERRIDE;

virtual void GetNavigationErrorStrings(

blink::WebFrame* frame,

const blink::WebURLRequest& failed_request,

« no previous file with comments | « no previous file | chrome/renderer/chrome_content_renderer_client.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')