chrome/renderer/chrome_content_renderer_client.cc - Issue 134183002: Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 134183002: Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fix nits Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | chrome/renderer/chrome_content_renderer_client_unittest.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 729d91402087ce61e83ba89d4fb43149cc47f935..69a2c4e088bcd0d185b145f2e3c9cf13bfce6fda 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -937,7 +937,9 @@ bool ChromeContentRendererClient::HasErrorPage(int http_status_code,

return true;

}

-bool ChromeContentRendererClient::ShouldSuppressErrorPage(const GURL& url) {

+bool ChromeContentRendererClient::ShouldSuppressErrorPage(

+ content::RenderFrame* render_frame,

+ const GURL& url) {

// Do not flash an error page if the Instant new tab page fails to load.

return search_bouncer_.get() && search_bouncer_->IsNewTabPage(url);

}