content/renderer/render_frame_impl.cc - Issue 134183002: Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 134183002: Pass frame to ChromeContentRendererClient::ShouldSuppressErrorPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fix nits Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 55b25367845fe18c2ca0c7a2681f622aaf77a0d3..40ecaa0add1cc96b1b59d6432f98b6bfec0a50e9 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -956,7 +956,7 @@ void RenderFrameImpl::didFailProvisionalLoad(

}

// Allow the embedder to suppress an error page.

- if (GetContentClient()->renderer()->ShouldSuppressErrorPage(

+ if (GetContentClient()->renderer()->ShouldSuppressErrorPage(this,

jam 2014/01/10 18:26:44 nit: according to style guide, the first parameter

error.unreachableURL)) {

return;

}

« no previous file with comments | « content/public/renderer/content_renderer_client.cc ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »