Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1337943003: [tracing] Non-functional refactor of memory dump arg names (Closed)

Created:
5 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, tracing+reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Non-functional refactor of memory dump arg names This CL is just cleaning up the inconsistencies accumulated w.r.t. of names used in the TraceConfig vs enum names in the codebase. Also this simplifies the complex and unnecessary wrapping in of the level of details argument in the RequestGlobalMemoryDump() API. BUG= TBR=jochen@chromium.org,reed@google.com Committed: https://crrev.com/82baa9afc6620c68cb2168f20bb65e77e3e57f0a Cr-Commit-Position: refs/heads/master@{#348715}

Patch Set 1 #

Patch Set 2 : cl format #

Patch Set 3 : Add missing <string> #

Patch Set 4 : Fix windows test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -146 lines) Patch
M base/trace_event/java_heap_dump_provider_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_allocator_dump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_dump_manager.h View 1 chunk +2 lines, -3 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 5 chunks +19 lines, -17 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 23 chunks +32 lines, -45 lines 0 comments Download
M base/trace_event/memory_dump_provider.h View 1 chunk +4 lines, -10 lines 0 comments Download
M base/trace_event/memory_dump_request_args.h View 1 2 3 chunks +24 lines, -7 lines 0 comments Download
M base/trace_event/memory_dump_request_args.cc View 1 chunk +28 lines, -7 lines 0 comments Download
M base/trace_event/process_memory_dump.h View 1 chunk +2 lines, -6 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/process_memory_maps_dump_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/process_memory_totals_dump_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_config.cc View 5 chunks +9 lines, -24 lines 0 comments Download
M base/trace_event/trace_config_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/winheap_dump_provider_win_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/tracing/tracing_messages.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/tracing/memory_tracing_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/web_memory_dump_provider_adapter.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M gin/v8_isolate_memory_dump_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M gin/v8_isolate_memory_dump_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_memory_dump_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
Primiano Tucci (use gerrit)
This is just a renaming cleanup, making everything consistent. Thanks.
5 years, 3 months ago (2015-09-11 18:09:37 UTC) #2
dsinclair
lgtm
5 years, 3 months ago (2015-09-11 19:21:25 UTC) #3
Primiano Tucci (use gerrit)
+kenrb for components/tracing/tracing_messages.h
5 years, 3 months ago (2015-09-14 07:54:58 UTC) #5
kenrb
ipc lgtm
5 years, 3 months ago (2015-09-14 15:56:55 UTC) #6
Primiano Tucci (use gerrit)
TBR for the remaining trivial renames jochen@ for : content/ and gin/ reed@ for skia/
5 years, 3 months ago (2015-09-14 17:46:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337943003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337943003/40001
5 years, 3 months ago (2015-09-14 17:48:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/103607)
5 years, 3 months ago (2015-09-14 18:23:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337943003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337943003/60001
5 years, 3 months ago (2015-09-14 18:38:13 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-14 20:44:32 UTC) #17
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/82baa9afc6620c68cb2168f20bb65e77e3e57f0a Cr-Commit-Position: refs/heads/master@{#348715}
5 years, 3 months ago (2015-09-14 20:45:20 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:37:06 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/82baa9afc6620c68cb2168f20bb65e77e3e57f0a
Cr-Commit-Position: refs/heads/master@{#348715}

Powered by Google App Engine
This is Rietveld 408576698