Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: base/trace_event/trace_config_unittest.cc

Issue 1337943003: [tracing] Non-functional refactor of memory dump arg names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix windows test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/trace_event/memory_dump_manager.h" 5 #include "base/trace_event/memory_dump_manager.h"
6 #include "base/trace_event/trace_config.h" 6 #include "base/trace_event/trace_config.h"
7 #include "base/trace_event/trace_config_memory_test_util.h" 7 #include "base/trace_event/trace_config_memory_test_util.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace base { 10 namespace base {
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 491
492 TEST(TraceConfigTest, TraceConfigFromMemoryConfigString) { 492 TEST(TraceConfigTest, TraceConfigFromMemoryConfigString) {
493 std::string tc_str = 493 std::string tc_str =
494 TraceConfigMemoryTestUtil::GetTraceConfig_PeriodicTriggers(200, 2000); 494 TraceConfigMemoryTestUtil::GetTraceConfig_PeriodicTriggers(200, 2000);
495 TraceConfig tc(tc_str); 495 TraceConfig tc(tc_str);
496 EXPECT_EQ(tc_str, tc.ToString()); 496 EXPECT_EQ(tc_str, tc.ToString());
497 EXPECT_TRUE(tc.IsCategoryGroupEnabled(MemoryDumpManager::kTraceCategory)); 497 EXPECT_TRUE(tc.IsCategoryGroupEnabled(MemoryDumpManager::kTraceCategory));
498 EXPECT_EQ(2u, tc.memory_dump_config_.size()); 498 EXPECT_EQ(2u, tc.memory_dump_config_.size());
499 499
500 EXPECT_EQ(200u, tc.memory_dump_config_[0].periodic_interval_ms); 500 EXPECT_EQ(200u, tc.memory_dump_config_[0].periodic_interval_ms);
501 EXPECT_EQ(MemoryDumpArgs::LevelOfDetail::LOW, 501 EXPECT_EQ(MemoryDumpLevelOfDetail::LIGHT,
502 tc.memory_dump_config_[0].level_of_detail); 502 tc.memory_dump_config_[0].level_of_detail);
503 503
504 EXPECT_EQ(2000u, tc.memory_dump_config_[1].periodic_interval_ms); 504 EXPECT_EQ(2000u, tc.memory_dump_config_[1].periodic_interval_ms);
505 EXPECT_EQ(MemoryDumpArgs::LevelOfDetail::HIGH, 505 EXPECT_EQ(MemoryDumpLevelOfDetail::DETAILED,
506 tc.memory_dump_config_[1].level_of_detail); 506 tc.memory_dump_config_[1].level_of_detail);
507 } 507 }
508 508
509 TEST(TraceConfigTest, EmptyMemoryDumpConfigTest) { 509 TEST(TraceConfigTest, EmptyMemoryDumpConfigTest) {
510 // Empty trigger list should also be specified when converting back to string. 510 // Empty trigger list should also be specified when converting back to string.
511 TraceConfig tc(TraceConfigMemoryTestUtil::GetTraceConfig_EmptyTriggers()); 511 TraceConfig tc(TraceConfigMemoryTestUtil::GetTraceConfig_EmptyTriggers());
512 EXPECT_EQ(TraceConfigMemoryTestUtil::GetTraceConfig_EmptyTriggers(), 512 EXPECT_EQ(TraceConfigMemoryTestUtil::GetTraceConfig_EmptyTriggers(),
513 tc.ToString()); 513 tc.ToString());
514 EXPECT_EQ(0u, tc.memory_dump_config_.size()); 514 EXPECT_EQ(0u, tc.memory_dump_config_.size());
515 } 515 }
516 516
517 TEST(TraceConfigTest, LegacyStringToMemoryDumpConfig) { 517 TEST(TraceConfigTest, LegacyStringToMemoryDumpConfig) {
518 TraceConfig tc(MemoryDumpManager::kTraceCategory, ""); 518 TraceConfig tc(MemoryDumpManager::kTraceCategory, "");
519 EXPECT_TRUE(tc.IsCategoryGroupEnabled(MemoryDumpManager::kTraceCategory)); 519 EXPECT_TRUE(tc.IsCategoryGroupEnabled(MemoryDumpManager::kTraceCategory));
520 EXPECT_NE(std::string::npos, tc.ToString().find("memory_dump_config")); 520 EXPECT_NE(std::string::npos, tc.ToString().find("memory_dump_config"));
521 EXPECT_EQ(2u, tc.memory_dump_config_.size()); 521 EXPECT_EQ(2u, tc.memory_dump_config_.size());
522 } 522 }
523 523
524 } // namespace trace_event 524 } // namespace trace_event
525 } // namespace base 525 } // namespace base
OLDNEW
« no previous file with comments | « base/trace_event/trace_config.cc ('k') | base/trace_event/winheap_dump_provider_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698