base/trace_event/process_memory_maps_dump_provider_unittest.cc - Issue 1337943003: [tracing] Non-functional refactor of memory dump arg names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_maps_dump_provider_unittest.cc

Issue 1337943003: [tracing] Non-functional refactor of memory dump arg names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix windows test Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/process_memory_maps_dump_provider.cc ('k') | base/trace_event/process_memory_totals_dump_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/process_memory_maps_dump_provider_unittest.cc

diff --git a/base/trace_event/process_memory_maps_dump_provider_unittest.cc b/base/trace_event/process_memory_maps_dump_provider_unittest.cc

index f951a09fb8a2aaf84a290a96ece8bf0db26a3518..a73a21c772e9581d1d72bb9b98dbf03cc3627277 100644

--- a/base/trace_event/process_memory_maps_dump_provider_unittest.cc

+++ b/base/trace_event/process_memory_maps_dump_provider_unittest.cc

@@ -110,7 +110,7 @@ TEST(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps) {

const uint32 kProtR = ProcessMemoryMaps::VMRegion::kProtectionFlagsRead;

const uint32 kProtW = ProcessMemoryMaps::VMRegion::kProtectionFlagsWrite;

const uint32 kProtX = ProcessMemoryMaps::VMRegion::kProtectionFlagsExec;

- const MemoryDumpArgs dump_args = {MemoryDumpArgs::LevelOfDetail::HIGH};

+ const MemoryDumpArgs dump_args = {MemoryDumpLevelOfDetail::DETAILED};

auto pmmdp = ProcessMemoryMapsDumpProvider::GetInstance();