components/tracing/tracing_messages.h - Issue 1337943003: [tracing] Non-functional refactor of memory dump arg names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/tracing_messages.h

Issue 1337943003: [tracing] Non-functional refactor of memory dump arg names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix windows test Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/winheap_dump_provider_win_unittest.cc ('k') | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/tracing/tracing_messages.h

diff --git a/components/tracing/tracing_messages.h b/components/tracing/tracing_messages.h

index b14254ed466e5e8576d5dab42bd151125b315630..11196e38d0ede22eab8b722ee77895a1c18559f4 100644

--- a/components/tracing/tracing_messages.h

+++ b/components/tracing/tracing_messages.h

@@ -29,16 +29,15 @@ IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(base::trace_event::MemoryDumpRequestArgs)

IPC_STRUCT_TRAITS_MEMBER(dump_guid)

IPC_STRUCT_TRAITS_MEMBER(dump_type)

-IPC_STRUCT_TRAITS_MEMBER(dump_args)

+IPC_STRUCT_TRAITS_MEMBER(level_of_detail)

IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(base::trace_event::MemoryDumpArgs)

IPC_STRUCT_TRAITS_MEMBER(level_of_detail)

IPC_STRUCT_TRAITS_END()

-IPC_ENUM_TRAITS_MAX_VALUE(

- base::trace_event::MemoryDumpArgs::LevelOfDetail,

- base::trace_event::MemoryDumpArgs::LevelOfDetail::LAST)

+IPC_ENUM_TRAITS_MAX_VALUE(base::trace_event::MemoryDumpLevelOfDetail,

+ base::trace_event::MemoryDumpLevelOfDetail::LAST)

IPC_ENUM_TRAITS_MAX_VALUE(

base::trace_event::MemoryDumpType,

« no previous file with comments | « base/trace_event/winheap_dump_provider_win_unittest.cc ('k') | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »