gin/v8_isolate_memory_dump_provider_unittest.cc - Issue 1337943003: [tracing] Non-functional refactor of memory dump arg names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/v8_isolate_memory_dump_provider_unittest.cc

Issue 1337943003: [tracing] Non-functional refactor of memory dump arg names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix windows test Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/v8_isolate_memory_dump_provider_unittest.cc

diff --git a/gin/v8_isolate_memory_dump_provider_unittest.cc b/gin/v8_isolate_memory_dump_provider_unittest.cc

index ed2ee6b143b1623d10e27abed763356ec49ee45e..3979a324fa327cc4d246df44687383872ab8fc61 100644

--- a/gin/v8_isolate_memory_dump_provider_unittest.cc

+++ b/gin/v8_isolate_memory_dump_provider_unittest.cc

@@ -24,7 +24,7 @@ TEST_F(V8MemoryDumpProviderTest, DumpStatistics) {

scoped_ptr<base::trace_event::ProcessMemoryDump> process_memory_dump(

new base::trace_event::ProcessMemoryDump(nullptr));

base::trace_event::MemoryDumpArgs dump_args = {

- base::trace_event::MemoryDumpArgs::LevelOfDetail::HIGH};

+ base::trace_event::MemoryDumpLevelOfDetail::DETAILED};

instance_->isolate_memory_dump_provider_for_testing()->OnMemoryDump(

dump_args, process_memory_dump.get());

const base::trace_event::ProcessMemoryDump::AllocatorDumpsMap&

« no previous file with comments | « gin/v8_isolate_memory_dump_provider.cc ('k') | skia/ext/skia_memory_dump_provider_unittest.cc » ('j') | no next file with comments »